[jira] [Commented] (DRILL-6717) lower and upper functions not works with national charactes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603763#comment-16603763 ] 

ASF GitHub Bot commented on DRILL-6717:
---------------------------------------

Ben-Zvi commented on issue #1450: DRILL-6717: lower and upper functions not works with national characters
URL: https://github.com/apache/drill/pull/1450#issuecomment-418558342
 
 
   @arina-ielchiieva - I'm still undecided; the Java technology is mature enough to handle national characters Up/Down case conversions, so why should we reimplement and add complexity ?  Any benefit to the PR code (over using _toUpperCase()_ , etc) ?
      I compared the performance (by adding Stopwatch calls around the conversions) by converting the same string in a loop -- the PR code initially performs poorly, then becomes on par with the _toUpperCase()_ code (likely the JIT improves). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> lower and upper functions not works with national charactes
> -----------------------------------------------------------
>
>                 Key: DRILL-6717
>                 URL: https://issues.apache.org/jira/browse/DRILL-6717
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.14.0
>            Reporter: Oleg Zinoviev
>            Assignee: Oleg Zinoviev
>            Priority: Major
>             Fix For: 1.15.0
>
>         Attachments: result.csv, sample.json
>
>
> upper() and lower() functions works only with a ascii characters.
> sample dataset:  [^sample.json] 
> query:
> {code:sql}
> select 
>   upper(ascii_l) as upper_ascii, 
>   upper(national_l) as upper_national, 
>   lower(ascii_u) as lower_ascii, 
>   lower(national_u) as lower_national 
> from dfs.`sample.json`
> {code}
> drill response:  [^result.csv] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)