You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/09/28 17:39:00 UTC

[jira] [Work logged] (TOMEE-4053) Dependency properties cleanup

     [ https://issues.apache.org/jira/browse/TOMEE-4053?focusedWorklogId=813073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813073 ]

ASF GitHub Bot logged work on TOMEE-4053:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Sep/22 17:38
            Start Date: 28/Sep/22 17:38
    Worklog Time Spent: 10m 
      Work Description: dblevins commented on PR #928:
URL: https://github.com/apache/tomee/pull/928#issuecomment-1261242285

   I think it's fantastic to get the version strings normalized to `version.foo`.  We started with `foo.version` and gradually changed to `version.foo` as that kind of thing became more favored by Maven in general, but we never went back and fixed the old properties so we have a mix.  Great to see that addressed.
   
   My preference would be to keep it short and go with straight `version.foo` versus adding prefixes before the `foo` part such as `tomee`, `api` or the groupId.  I'll never remember which prefix rule goes where and when, so I'll constantly be looking it up and also further adding to inconsistency.
   
   Intellij does have completion for Maven properties.  Being able to type `version.` and then get a flat list of all the names would be fantastic.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 813073)
    Remaining Estimate: 0h
            Time Spent: 10m

> Dependency properties cleanup
> -----------------------------
>
>                 Key: TOMEE-4053
>                 URL: https://issues.apache.org/jira/browse/TOMEE-4053
>             Project: TomEE
>          Issue Type: Improvement
>            Reporter: Gwénaël Ruelland
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Proposed PR for properties consistency 
>  * properties are of the form 'version.groupid' or 'groupid.version' : changed most to the 'version.groupid' form for coherence.
>  * regrouping properties by feature blocks
>  * ordering by name were usefull



--
This message was sent by Atlassian Jira
(v8.20.10#820010)