You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/28 17:22:45 UTC

[GitHub] [airflow] ashb commented on a change in pull request #16681: Introduce CLEARED_WHEN_RUNNING state

ashb commented on a change in pull request #16681:
URL: https://github.com/apache/airflow/pull/16681#discussion_r659976072



##########
File path: airflow/models/taskinstance.py
##########
@@ -1503,6 +1503,10 @@ def handle_failure_with_callback(
 
     def is_eligible_to_retry(self):
         """Is task instance is eligible for retry"""
+        if self.state == State.CLEARED_WHEN_RUNNING:
+            # If a task was cleared when running, it is always eligible for retry

Review comment:
       I am not sure you'd is the case. If it's already run its maximal number of tries out shouldn't run again should it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org