You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/12 04:06:05 UTC

[GitHub] [ozone] JacksonYao287 opened a new pull request, #3679: HDDS-7123. container scan should hold the container read lock

JacksonYao287 opened a new pull request, #3679:
URL: https://github.com/apache/ozone/pull/3679

   ## What changes were proposed in this pull request?
   
   now, when scanning container, datanode does not hold a lock. when the blockDeletingService works, it will first deletes the block file in container directory and then delete the metadata in rocksdb. when container scanner works , it will first read the metadata from DB, and then check the block file in container directory.  the two background service runs concurrently for now. there may be a case that when blockDeletingService deletes the block file from container directory but not delete the metadata from rocksdb, container scanner read the metadata from rocksdb and then fail to find the block file in container directory, and then mark the container replica unhealthy
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-7123
   
   ## How was this patch tested?
   
   no additional test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] JacksonYao287 commented on pull request #3679: HDDS-7123. container scan should hold the container read lock

Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on PR #3679:
URL: https://github.com/apache/ozone/pull/3679#issuecomment-1274276766

   @adoroszlai @Galsza there is another patch seems do the same work. #3811 
   i will close this PR , and help reviewing that one @Xushaohong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] JacksonYao287 closed pull request #3679: HDDS-7123. container scan should hold the container read lock

Posted by GitBox <gi...@apache.org>.
JacksonYao287 closed pull request #3679: HDDS-7123. container scan should hold the container read lock
URL: https://github.com/apache/ozone/pull/3679


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #3679: HDDS-7123. container scan should hold the container read lock

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3679:
URL: https://github.com/apache/ozone/pull/3679#issuecomment-1255474930

   /pending


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] Galsza commented on pull request #3679: HDDS-7123. container scan should hold the container read lock

Posted by GitBox <gi...@apache.org>.
Galsza commented on PR #3679:
URL: https://github.com/apache/ozone/pull/3679#issuecomment-1274222549

   @JacksonYao287 could you resolve Attila's comment?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org