You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by LiZhenNet <li...@gmail.com> on 2019/01/25 03:24:59 UTC
[Discuss] About Clean Code Plan
Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
methods ,unused logic , nonstandard naming in the code. And there are some
code that can use the new features of java to make the code more concise
and understandable. like Lambda , Diamond Operator and so on.These are easy
to find and fixed because of the tips of the idea .We should do it before
completing the incubation.
Re: [Discuss] About Clean Code Plan
Posted by yuhang xiu <ca...@gmail.com>.
Hi, @lizhen
Your pr seems to have some problems, so I have already commented below and
explained that please resubmit a pr. If you can solve this problem directly
on your branch, you can tell me, of course I will reopen your pr. But
before that, I didn't think that reviewing 30,000 lines of code was
necessary, and your pr could not be merged before you solved the problem,
so I turned it off.
Also, if you need to discuss anything, use an issue to track instead of
using pr to track, even if your pr is your purpose. That is a better
approach.
LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:58写道：
> I don't know why he showed that the entire file was modified, even though
> he only modified one line. You can check it.
>
> yuhang xiu <ca...@gmail.com> 于2019年1月29日周二 上午10:43写道：
>
> > Your pr has modified more than 30,000 lines of code, and most of them are
> > modifications of the entire file.
> > What is the meaning of your pr? Why do I need to keep it open?
> >
> > If you need to discuss, issues and mailing lists are good choices, why do
> > you need to discuss pr?
> >
> > Who can review this pr[1] and tell me what this pr is going to do?
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/3371
> >
> > LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> >
> > > Yes, we can create a project to manage it, and we can talk about it.
> > like:
> > > Should we used Diamond Operator replace explicit type? Use Lambda?
> > > Let's discuss the two pull requests above instead of closed it
> > immediately.
> > >
> > >
> > >
> > >
> > >
> > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> > >
> > > > Hi,
> > > >
> > > > Nice suggestion!
> > > >
> > > > Shall we can create a project to manage it?
> > > >
> > > > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> > > wrote:
> > > > >
> > > > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> > > unused
> > > > > methods ,unused logic , nonstandard naming in the code. And there
> > are
> > > > some
> > > > > code that can use the new features of java to make the code more
> > > concise
> > > > > and understandable. like Lambda , Diamond Operator and so on.These
> > are
> > > > easy
> > > > > to find and fixed because of the tips of the idea .We should do it
> > > before
> > > > > completing the incubation.
> > > >
> > > >
> > > >
> > > > --
> > > > Best Regards！
> > > > Huxing
> > > >
> > >
> >
>
Re: [Discuss] About Clean Code Plan
Posted by LiZhenNet <li...@gmail.com>.
I don't know why he showed that the entire file was modified, even though
he only modified one line. You can check it.
yuhang xiu <ca...@gmail.com> 于2019年1月29日周二 上午10:43写道：
> Your pr has modified more than 30,000 lines of code, and most of them are
> modifications of the entire file.
> What is the meaning of your pr? Why do I need to keep it open?
>
> If you need to discuss, issues and mailing lists are good choices, why do
> you need to discuss pr?
>
> Who can review this pr[1] and tell me what this pr is going to do?
>
> [1] https://github.com/apache/incubator-dubbo/pull/3371
>
> LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
>
> > Yes, we can create a project to manage it, and we can talk about it.
> like:
> > Should we used Diamond Operator replace explicit type? Use Lambda?
> > Let's discuss the two pull requests above instead of closed it
> immediately.
> >
> >
> >
> >
> >
> > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> >
> > > Hi,
> > >
> > > Nice suggestion!
> > >
> > > Shall we can create a project to manage it?
> > >
> > > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> > wrote:
> > > >
> > > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> > unused
> > > > methods ,unused logic , nonstandard naming in the code. And there
> are
> > > some
> > > > code that can use the new features of java to make the code more
> > concise
> > > > and understandable. like Lambda , Diamond Operator and so on.These
> are
> > > easy
> > > > to find and fixed because of the tips of the idea .We should do it
> > before
> > > > completing the incubation.
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> >
>
Re: Re: [Discuss] About Clean Code Plan
Posted by "zhi_guang_liu@163.com" <zh...@163.com>.
I agree with you very much.
您的朋友：刘志广
From: Ian Luo
Date: 2019-01-29 14:38
To: dev
Subject: Re: [Discuss] About Clean Code Plan
Jason,
Totally agree with you on this point. We should focus less on grammar sugar
but focus more on make the code clean, for say: divide long method into
shorter methods, better naming, or better doc, or even better design.
But on the other hand, if someone from the community shows enthusiasm for
updating code with new sugar, I will not object to the effort as long as it
doesn't hurt readability, after all it is low hanging fruit :)
What I propose is we should gather all possible ideas and group them in one
project on GitHub [1], like I said in my previous email. It is critical to
make the code clean as much as possible in my opinion. It deserves one
dedicated project to track all ideas. By doing this, the community can also
understand the current focuses are.
So my question is, should we init a project focusing on clean code, while
the purpose doesn't limit to grammar sugar?
Regards,
-Ian.
1. https://github.com/apache/incubator-dubbo/projects
On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <hb...@163.com> wrote:
> Hi, Huxing & LiZhen
>
> Things like diamond is something called grammar SUGAR.
> Tasted good for developers but the same on byte code.
>
> So in my opinion we should not take it as a kind of "policy correct".
> we can make the changes in the code of recent PRs but not for all the
> code. Think about there may be more sugars in future JVM.
>
> best regards,
>
> Jason
>
> > On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
> >
> > Your pr has modified more than 30,000 lines of code, and most of them are
> > modifications of the entire file.
> > What is the meaning of your pr? Why do I need to keep it open?
> >
> > If you need to discuss, issues and mailing lists are good choices, why do
> > you need to discuss pr?
> >
> > Who can review this pr[1] and tell me what this pr is going to do?
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/3371
> >
> > LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> >
> >> Yes, we can create a project to manage it, and we can talk about it.
> like:
> >> Should we used Diamond Operator replace explicit type? Use Lambda?
> >> Let's discuss the two pull requests above instead of closed it
> immediately.
> >>
> >>
> >>
> >>
> >>
> >> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> >>
> >>> Hi,
> >>>
> >>> Nice suggestion!
> >>>
> >>> Shall we can create a project to manage it?
> >>>
> >>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> >> wrote:
> >>>>
> >>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> >> unused
> >>>> methods ,unused logic , nonstandard naming in the code. And there are
> >>> some
> >>>> code that can use the new features of java to make the code more
> >> concise
> >>>> and understandable. like Lambda , Diamond Operator and so on.These are
> >>> easy
> >>>> to find and fixed because of the tips of the idea .We should do it
> >> before
> >>>> completing the incubation.
> >>>
> >>>
> >>>
> >>> --
> >>> Best Regards！
> >>> Huxing
> >>>
> >>
>
>
Re: [Discuss] About Clean Code Plan
Posted by Ian Luo <ia...@gmail.com>.
Imteyaz,
Basically we are discussing whether and how to make an effort to make the
code clean, and whether it's worth of a dedicated project, though we all
understand it is a day-to-day requirement for all engineers in every single
submit.
Regards,
-Ian.
On Wed, Jan 30, 2019 at 12:09 AM Imteyaz Khan <kh...@gmail.com>
wrote:
> sorry I was not following the thread actively so might have missed
> something. how are planning the clean code approach as module by module or
> will start with any new code modifications wise ?
>
> On Tuesday, January 29, 2019, LiZhenNet <li...@gmail.com> wrote:
>
> > +1 ,
> > Grammar sugar can easily be fixed by using Idea's Analyze. What deserves
> > attention is the duplicate code and logic optimization.
> >
> >
> > Jason Joo <hb...@163.com> 于2019年1月29日周二 下午3:38写道：
> >
> > > Hi, lan
> > >
> > > Agree with you.
> > >
> > > It's great for shorter, cleaner, more efficient logic optimizing. So I
> > > suggest that modifications including grammar sugar purposed for
> shorter,
> > > cleaner or more efficient are great but not just rewriting with another
> > > form. I surely will not object it, too.
> > >
> > > But pay attention to some features or new styles that will generate
> more
> > > objects.
> > >
> > > I think it would be more simple and easy we organize these as a kind of
> > > issue. Focused and small PRs are easy to review after all.
> > >
> > > best regards,
> > >
> > > Jason
> > >
> > > > On Jan 29, 2019, at 14:38, Ian Luo <ia...@gmail.com> wrote:
> > > >
> > > > Jason,
> > > >
> > > > Totally agree with you on this point. We should focus less on grammar
> > > sugar
> > > > but focus more on make the code clean, for say: divide long method
> into
> > > > shorter methods, better naming, or better doc, or even better design.
> > > >
> > > > But on the other hand, if someone from the community shows enthusiasm
> > for
> > > > updating code with new sugar, I will not object to the effort as long
> > as
> > > it
> > > > doesn't hurt readability, after all it is low hanging fruit :)
> > > >
> > > > What I propose is we should gather all possible ideas and group them
> in
> > > one
> > > > project on GitHub [1], like I said in my previous email. It is
> critical
> > > to
> > > > make the code clean as much as possible in my opinion. It deserves
> one
> > > > dedicated project to track all ideas. By doing this, the community
> can
> > > also
> > > > understand the current focuses are.
> > > >
> > > > So my question is, should we init a project focusing on clean code,
> > while
> > > > the purpose doesn't limit to grammar sugar?
> > > >
> > > > Regards,
> > > > -Ian.
> > > >
> > > > 1. https://github.com/apache/incubator-dubbo/projects
> > > >
> > > > On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <hb...@163.com> wrote:
> > > >
> > > >> Hi, Huxing & LiZhen
> > > >>
> > > >> Things like diamond is something called grammar SUGAR.
> > > >> Tasted good for developers but the same on byte code.
> > > >>
> > > >> So in my opinion we should not take it as a kind of "policy
> correct".
> > > >> we can make the changes in the code of recent PRs but not for all
> the
> > > >> code. Think about there may be more sugars in future JVM.
> > > >>
> > > >> best regards,
> > > >>
> > > >> Jason
> > > >>
> > > >>> On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
> > > >>>
> > > >>> Your pr has modified more than 30,000 lines of code, and most of
> them
> > > are
> > > >>> modifications of the entire file.
> > > >>> What is the meaning of your pr? Why do I need to keep it open?
> > > >>>
> > > >>> If you need to discuss, issues and mailing lists are good choices,
> > why
> > > do
> > > >>> you need to discuss pr?
> > > >>>
> > > >>> Who can review this pr[1] and tell me what this pr is going to do?
> > > >>>
> > > >>> [1] https://github.com/apache/incubator-dubbo/pull/3371
> > > >>>
> > > >>> LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> > > >>>
> > > >>>> Yes, we can create a project to manage it, and we can talk about
> it.
> > > >> like:
> > > >>>> Should we used Diamond Operator replace explicit type? Use
> Lambda?
> > > >>>> Let's discuss the two pull requests above instead of closed it
> > > >> immediately.
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> > > >>>>
> > > >>>>> Hi,
> > > >>>>>
> > > >>>>> Nice suggestion!
> > > >>>>>
> > > >>>>> Shall we can create a project to manage it?
> > > >>>>>
> > > >>>>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <
> lizhencoder@gmail.com>
> > > >>>> wrote:
> > > >>>>>>
> > > >>>>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot
> of
> > > >>>> unused
> > > >>>>>> methods ,unused logic , nonstandard naming in the code. And
> there
> > > are
> > > >>>>> some
> > > >>>>>> code that can use the new features of java to make the code more
> > > >>>> concise
> > > >>>>>> and understandable. like Lambda , Diamond Operator and so
> on.These
> > > are
> > > >>>>> easy
> > > >>>>>> to find and fixed because of the tips of the idea .We should do
> it
> > > >>>> before
> > > >>>>>> completing the incubation.
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>> --
> > > >>>>> Best Regards！
> > > >>>>> Huxing
> > > >>>>>
> > > >>>>
> > > >>
> > > >>
> > >
> > >
> >
>
Re: [Discuss] About Clean Code Plan
Posted by LiZhenNet <li...@gmail.com>.
Good Idea, I will do it like this next time.
Re: [Discuss] About Clean Code Plan
Posted by Imteyaz Khan <kh...@gmail.com>.
sorry I was not following the thread actively so might have missed
something. how are planning the clean code approach as module by module or
will start with any new code modifications wise ?
On Tuesday, January 29, 2019, LiZhenNet <li...@gmail.com> wrote:
> +1 ,
> Grammar sugar can easily be fixed by using Idea's Analyze. What deserves
> attention is the duplicate code and logic optimization.
>
>
> Jason Joo <hb...@163.com> 于2019年1月29日周二 下午3:38写道：
>
> > Hi, lan
> >
> > Agree with you.
> >
> > It's great for shorter, cleaner, more efficient logic optimizing. So I
> > suggest that modifications including grammar sugar purposed for shorter,
> > cleaner or more efficient are great but not just rewriting with another
> > form. I surely will not object it, too.
> >
> > But pay attention to some features or new styles that will generate more
> > objects.
> >
> > I think it would be more simple and easy we organize these as a kind of
> > issue. Focused and small PRs are easy to review after all.
> >
> > best regards,
> >
> > Jason
> >
> > > On Jan 29, 2019, at 14:38, Ian Luo <ia...@gmail.com> wrote:
> > >
> > > Jason,
> > >
> > > Totally agree with you on this point. We should focus less on grammar
> > sugar
> > > but focus more on make the code clean, for say: divide long method into
> > > shorter methods, better naming, or better doc, or even better design.
> > >
> > > But on the other hand, if someone from the community shows enthusiasm
> for
> > > updating code with new sugar, I will not object to the effort as long
> as
> > it
> > > doesn't hurt readability, after all it is low hanging fruit :)
> > >
> > > What I propose is we should gather all possible ideas and group them in
> > one
> > > project on GitHub [1], like I said in my previous email. It is critical
> > to
> > > make the code clean as much as possible in my opinion. It deserves one
> > > dedicated project to track all ideas. By doing this, the community can
> > also
> > > understand the current focuses are.
> > >
> > > So my question is, should we init a project focusing on clean code,
> while
> > > the purpose doesn't limit to grammar sugar?
> > >
> > > Regards,
> > > -Ian.
> > >
> > > 1. https://github.com/apache/incubator-dubbo/projects
> > >
> > > On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <hb...@163.com> wrote:
> > >
> > >> Hi, Huxing & LiZhen
> > >>
> > >> Things like diamond is something called grammar SUGAR.
> > >> Tasted good for developers but the same on byte code.
> > >>
> > >> So in my opinion we should not take it as a kind of "policy correct".
> > >> we can make the changes in the code of recent PRs but not for all the
> > >> code. Think about there may be more sugars in future JVM.
> > >>
> > >> best regards,
> > >>
> > >> Jason
> > >>
> > >>> On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
> > >>>
> > >>> Your pr has modified more than 30,000 lines of code, and most of them
> > are
> > >>> modifications of the entire file.
> > >>> What is the meaning of your pr? Why do I need to keep it open?
> > >>>
> > >>> If you need to discuss, issues and mailing lists are good choices,
> why
> > do
> > >>> you need to discuss pr?
> > >>>
> > >>> Who can review this pr[1] and tell me what this pr is going to do?
> > >>>
> > >>> [1] https://github.com/apache/incubator-dubbo/pull/3371
> > >>>
> > >>> LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> > >>>
> > >>>> Yes, we can create a project to manage it, and we can talk about it.
> > >> like:
> > >>>> Should we used Diamond Operator replace explicit type? Use Lambda?
> > >>>> Let's discuss the two pull requests above instead of closed it
> > >> immediately.
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> > >>>>
> > >>>>> Hi,
> > >>>>>
> > >>>>> Nice suggestion!
> > >>>>>
> > >>>>> Shall we can create a project to manage it?
> > >>>>>
> > >>>>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> > >>>> wrote:
> > >>>>>>
> > >>>>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> > >>>> unused
> > >>>>>> methods ,unused logic , nonstandard naming in the code. And there
> > are
> > >>>>> some
> > >>>>>> code that can use the new features of java to make the code more
> > >>>> concise
> > >>>>>> and understandable. like Lambda , Diamond Operator and so on.These
> > are
> > >>>>> easy
> > >>>>>> to find and fixed because of the tips of the idea .We should do it
> > >>>> before
> > >>>>>> completing the incubation.
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> --
> > >>>>> Best Regards！
> > >>>>> Huxing
> > >>>>>
> > >>>>
> > >>
> > >>
> >
> >
>
Re: [Discuss] About Clean Code Plan
Posted by LiZhenNet <li...@gmail.com>.
+1 ,
Grammar sugar can easily be fixed by using Idea's Analyze. What deserves
attention is the duplicate code and logic optimization.
Jason Joo <hb...@163.com> 于2019年1月29日周二 下午3:38写道：
> Hi, lan
>
> Agree with you.
>
> It's great for shorter, cleaner, more efficient logic optimizing. So I
> suggest that modifications including grammar sugar purposed for shorter,
> cleaner or more efficient are great but not just rewriting with another
> form. I surely will not object it, too.
>
> But pay attention to some features or new styles that will generate more
> objects.
>
> I think it would be more simple and easy we organize these as a kind of
> issue. Focused and small PRs are easy to review after all.
>
> best regards,
>
> Jason
>
> > On Jan 29, 2019, at 14:38, Ian Luo <ia...@gmail.com> wrote:
> >
> > Jason,
> >
> > Totally agree with you on this point. We should focus less on grammar
> sugar
> > but focus more on make the code clean, for say: divide long method into
> > shorter methods, better naming, or better doc, or even better design.
> >
> > But on the other hand, if someone from the community shows enthusiasm for
> > updating code with new sugar, I will not object to the effort as long as
> it
> > doesn't hurt readability, after all it is low hanging fruit :)
> >
> > What I propose is we should gather all possible ideas and group them in
> one
> > project on GitHub [1], like I said in my previous email. It is critical
> to
> > make the code clean as much as possible in my opinion. It deserves one
> > dedicated project to track all ideas. By doing this, the community can
> also
> > understand the current focuses are.
> >
> > So my question is, should we init a project focusing on clean code, while
> > the purpose doesn't limit to grammar sugar?
> >
> > Regards,
> > -Ian.
> >
> > 1. https://github.com/apache/incubator-dubbo/projects
> >
> > On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <hb...@163.com> wrote:
> >
> >> Hi, Huxing & LiZhen
> >>
> >> Things like diamond is something called grammar SUGAR.
> >> Tasted good for developers but the same on byte code.
> >>
> >> So in my opinion we should not take it as a kind of "policy correct".
> >> we can make the changes in the code of recent PRs but not for all the
> >> code. Think about there may be more sugars in future JVM.
> >>
> >> best regards,
> >>
> >> Jason
> >>
> >>> On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
> >>>
> >>> Your pr has modified more than 30,000 lines of code, and most of them
> are
> >>> modifications of the entire file.
> >>> What is the meaning of your pr? Why do I need to keep it open?
> >>>
> >>> If you need to discuss, issues and mailing lists are good choices, why
> do
> >>> you need to discuss pr?
> >>>
> >>> Who can review this pr[1] and tell me what this pr is going to do?
> >>>
> >>> [1] https://github.com/apache/incubator-dubbo/pull/3371
> >>>
> >>> LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> >>>
> >>>> Yes, we can create a project to manage it, and we can talk about it.
> >> like:
> >>>> Should we used Diamond Operator replace explicit type? Use Lambda?
> >>>> Let's discuss the two pull requests above instead of closed it
> >> immediately.
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>> Nice suggestion!
> >>>>>
> >>>>> Shall we can create a project to manage it?
> >>>>>
> >>>>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> >>>> wrote:
> >>>>>>
> >>>>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> >>>> unused
> >>>>>> methods ,unused logic , nonstandard naming in the code. And there
> are
> >>>>> some
> >>>>>> code that can use the new features of java to make the code more
> >>>> concise
> >>>>>> and understandable. like Lambda , Diamond Operator and so on.These
> are
> >>>>> easy
> >>>>>> to find and fixed because of the tips of the idea .We should do it
> >>>> before
> >>>>>> completing the incubation.
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Best Regards！
> >>>>> Huxing
> >>>>>
> >>>>
> >>
> >>
>
>
Re: [Discuss] About Clean Code Plan
Posted by Imteyaz Khan <kh...@gmail.com>.
Ian,
Thanks for summarizing this for me. I personally very excited about
this. 👍
On Wed, Jan 30, 2019 at 12:33 PM Ian Luo <ia...@gmail.com> wrote:
> Jason,
>
> Agree, and pls. join us and keep an eye on this area for us :)
>
> Thanks,
> -Ian.
>
>
> On Tue, Jan 29, 2019 at 3:38 PM Jason Joo <hb...@163.com> wrote:
>
> > Hi, lan
> >
> > Agree with you.
> >
> > It's great for shorter, cleaner, more efficient logic optimizing. So I
> > suggest that modifications including grammar sugar purposed for shorter,
> > cleaner or more efficient are great but not just rewriting with another
> > form. I surely will not object it, too.
> >
> > But pay attention to some features or new styles that will generate more
> > objects.
> >
> > I think it would be more simple and easy we organize these as a kind of
> > issue. Focused and small PRs are easy to review after all.
> >
> > best regards,
> >
> > Jason
> >
> > > On Jan 29, 2019, at 14:38, Ian Luo <ia...@gmail.com> wrote:
> > >
> > > Jason,
> > >
> > > Totally agree with you on this point. We should focus less on grammar
> > sugar
> > > but focus more on make the code clean, for say: divide long method into
> > > shorter methods, better naming, or better doc, or even better design.
> > >
> > > But on the other hand, if someone from the community shows enthusiasm
> for
> > > updating code with new sugar, I will not object to the effort as long
> as
> > it
> > > doesn't hurt readability, after all it is low hanging fruit :)
> > >
> > > What I propose is we should gather all possible ideas and group them in
> > one
> > > project on GitHub [1], like I said in my previous email. It is critical
> > to
> > > make the code clean as much as possible in my opinion. It deserves one
> > > dedicated project to track all ideas. By doing this, the community can
> > also
> > > understand the current focuses are.
> > >
> > > So my question is, should we init a project focusing on clean code,
> while
> > > the purpose doesn't limit to grammar sugar?
> > >
> > > Regards,
> > > -Ian.
> > >
> > > 1. https://github.com/apache/incubator-dubbo/projects
> > >
> > > On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <hb...@163.com> wrote:
> > >
> > >> Hi, Huxing & LiZhen
> > >>
> > >> Things like diamond is something called grammar SUGAR.
> > >> Tasted good for developers but the same on byte code.
> > >>
> > >> So in my opinion we should not take it as a kind of "policy correct".
> > >> we can make the changes in the code of recent PRs but not for all the
> > >> code. Think about there may be more sugars in future JVM.
> > >>
> > >> best regards,
> > >>
> > >> Jason
> > >>
> > >>> On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
> > >>>
> > >>> Your pr has modified more than 30,000 lines of code, and most of them
> > are
> > >>> modifications of the entire file.
> > >>> What is the meaning of your pr? Why do I need to keep it open?
> > >>>
> > >>> If you need to discuss, issues and mailing lists are good choices,
> why
> > do
> > >>> you need to discuss pr?
> > >>>
> > >>> Who can review this pr[1] and tell me what this pr is going to do?
> > >>>
> > >>> [1] https://github.com/apache/incubator-dubbo/pull/3371
> > >>>
> > >>> LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> > >>>
> > >>>> Yes, we can create a project to manage it, and we can talk about it.
> > >> like:
> > >>>> Should we used Diamond Operator replace explicit type? Use Lambda?
> > >>>> Let's discuss the two pull requests above instead of closed it
> > >> immediately.
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> > >>>>
> > >>>>> Hi,
> > >>>>>
> > >>>>> Nice suggestion!
> > >>>>>
> > >>>>> Shall we can create a project to manage it?
> > >>>>>
> > >>>>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> > >>>> wrote:
> > >>>>>>
> > >>>>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> > >>>> unused
> > >>>>>> methods ,unused logic , nonstandard naming in the code. And there
> > are
> > >>>>> some
> > >>>>>> code that can use the new features of java to make the code more
> > >>>> concise
> > >>>>>> and understandable. like Lambda , Diamond Operator and so on.These
> > are
> > >>>>> easy
> > >>>>>> to find and fixed because of the tips of the idea .We should do it
> > >>>> before
> > >>>>>> completing the incubation.
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> --
> > >>>>> Best Regards！
> > >>>>> Huxing
> > >>>>>
> > >>>>
> > >>
> > >>
> >
> >
>
Re: [Discuss] About Clean Code Plan
Posted by Ian Luo <ia...@gmail.com>.
Jason,
Agree, and pls. join us and keep an eye on this area for us :)
Thanks,
-Ian.
On Tue, Jan 29, 2019 at 3:38 PM Jason Joo <hb...@163.com> wrote:
> Hi, lan
>
> Agree with you.
>
> It's great for shorter, cleaner, more efficient logic optimizing. So I
> suggest that modifications including grammar sugar purposed for shorter,
> cleaner or more efficient are great but not just rewriting with another
> form. I surely will not object it, too.
>
> But pay attention to some features or new styles that will generate more
> objects.
>
> I think it would be more simple and easy we organize these as a kind of
> issue. Focused and small PRs are easy to review after all.
>
> best regards,
>
> Jason
>
> > On Jan 29, 2019, at 14:38, Ian Luo <ia...@gmail.com> wrote:
> >
> > Jason,
> >
> > Totally agree with you on this point. We should focus less on grammar
> sugar
> > but focus more on make the code clean, for say: divide long method into
> > shorter methods, better naming, or better doc, or even better design.
> >
> > But on the other hand, if someone from the community shows enthusiasm for
> > updating code with new sugar, I will not object to the effort as long as
> it
> > doesn't hurt readability, after all it is low hanging fruit :)
> >
> > What I propose is we should gather all possible ideas and group them in
> one
> > project on GitHub [1], like I said in my previous email. It is critical
> to
> > make the code clean as much as possible in my opinion. It deserves one
> > dedicated project to track all ideas. By doing this, the community can
> also
> > understand the current focuses are.
> >
> > So my question is, should we init a project focusing on clean code, while
> > the purpose doesn't limit to grammar sugar?
> >
> > Regards,
> > -Ian.
> >
> > 1. https://github.com/apache/incubator-dubbo/projects
> >
> > On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <hb...@163.com> wrote:
> >
> >> Hi, Huxing & LiZhen
> >>
> >> Things like diamond is something called grammar SUGAR.
> >> Tasted good for developers but the same on byte code.
> >>
> >> So in my opinion we should not take it as a kind of "policy correct".
> >> we can make the changes in the code of recent PRs but not for all the
> >> code. Think about there may be more sugars in future JVM.
> >>
> >> best regards,
> >>
> >> Jason
> >>
> >>> On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
> >>>
> >>> Your pr has modified more than 30,000 lines of code, and most of them
> are
> >>> modifications of the entire file.
> >>> What is the meaning of your pr? Why do I need to keep it open?
> >>>
> >>> If you need to discuss, issues and mailing lists are good choices, why
> do
> >>> you need to discuss pr?
> >>>
> >>> Who can review this pr[1] and tell me what this pr is going to do?
> >>>
> >>> [1] https://github.com/apache/incubator-dubbo/pull/3371
> >>>
> >>> LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> >>>
> >>>> Yes, we can create a project to manage it, and we can talk about it.
> >> like:
> >>>> Should we used Diamond Operator replace explicit type? Use Lambda?
> >>>> Let's discuss the two pull requests above instead of closed it
> >> immediately.
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>> Nice suggestion!
> >>>>>
> >>>>> Shall we can create a project to manage it?
> >>>>>
> >>>>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> >>>> wrote:
> >>>>>>
> >>>>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> >>>> unused
> >>>>>> methods ,unused logic , nonstandard naming in the code. And there
> are
> >>>>> some
> >>>>>> code that can use the new features of java to make the code more
> >>>> concise
> >>>>>> and understandable. like Lambda , Diamond Operator and so on.These
> are
> >>>>> easy
> >>>>>> to find and fixed because of the tips of the idea .We should do it
> >>>> before
> >>>>>> completing the incubation.
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Best Regards！
> >>>>> Huxing
> >>>>>
> >>>>
> >>
> >>
>
>
Re: [Discuss] About Clean Code Plan
Posted by Jason Joo <hb...@163.com>.
Hi, lan
Agree with you.
It's great for shorter, cleaner, more efficient logic optimizing. So I suggest that modifications including grammar sugar purposed for shorter, cleaner or more efficient are great but not just rewriting with another form. I surely will not object it, too.
But pay attention to some features or new styles that will generate more objects.
I think it would be more simple and easy we organize these as a kind of issue. Focused and small PRs are easy to review after all.
best regards,
Jason
> On Jan 29, 2019, at 14:38, Ian Luo <ia...@gmail.com> wrote:
>
> Jason,
>
> Totally agree with you on this point. We should focus less on grammar sugar
> but focus more on make the code clean, for say: divide long method into
> shorter methods, better naming, or better doc, or even better design.
>
> But on the other hand, if someone from the community shows enthusiasm for
> updating code with new sugar, I will not object to the effort as long as it
> doesn't hurt readability, after all it is low hanging fruit :)
>
> What I propose is we should gather all possible ideas and group them in one
> project on GitHub [1], like I said in my previous email. It is critical to
> make the code clean as much as possible in my opinion. It deserves one
> dedicated project to track all ideas. By doing this, the community can also
> understand the current focuses are.
>
> So my question is, should we init a project focusing on clean code, while
> the purpose doesn't limit to grammar sugar?
>
> Regards,
> -Ian.
>
> 1. https://github.com/apache/incubator-dubbo/projects
>
> On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <hb...@163.com> wrote:
>
>> Hi, Huxing & LiZhen
>>
>> Things like diamond is something called grammar SUGAR.
>> Tasted good for developers but the same on byte code.
>>
>> So in my opinion we should not take it as a kind of "policy correct".
>> we can make the changes in the code of recent PRs but not for all the
>> code. Think about there may be more sugars in future JVM.
>>
>> best regards,
>>
>> Jason
>>
>>> On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
>>>
>>> Your pr has modified more than 30,000 lines of code, and most of them are
>>> modifications of the entire file.
>>> What is the meaning of your pr? Why do I need to keep it open?
>>>
>>> If you need to discuss, issues and mailing lists are good choices, why do
>>> you need to discuss pr?
>>>
>>> Who can review this pr[1] and tell me what this pr is going to do?
>>>
>>> [1] https://github.com/apache/incubator-dubbo/pull/3371
>>>
>>> LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
>>>
>>>> Yes, we can create a project to manage it, and we can talk about it.
>> like:
>>>> Should we used Diamond Operator replace explicit type? Use Lambda?
>>>> Let's discuss the two pull requests above instead of closed it
>> immediately.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
>>>>
>>>>> Hi,
>>>>>
>>>>> Nice suggestion!
>>>>>
>>>>> Shall we can create a project to manage it?
>>>>>
>>>>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
>>>> wrote:
>>>>>>
>>>>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
>>>> unused
>>>>>> methods ,unused logic , nonstandard naming in the code. And there are
>>>>> some
>>>>>> code that can use the new features of java to make the code more
>>>> concise
>>>>>> and understandable. like Lambda , Diamond Operator and so on.These are
>>>>> easy
>>>>>> to find and fixed because of the tips of the idea .We should do it
>>>> before
>>>>>> completing the incubation.
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards！
>>>>> Huxing
>>>>>
>>>>
>>
>>
Re: [Discuss] About Clean Code Plan
Posted by Ian Luo <ia...@gmail.com>.
Jason,
Totally agree with you on this point. We should focus less on grammar sugar
but focus more on make the code clean, for say: divide long method into
shorter methods, better naming, or better doc, or even better design.
But on the other hand, if someone from the community shows enthusiasm for
updating code with new sugar, I will not object to the effort as long as it
doesn't hurt readability, after all it is low hanging fruit :)
What I propose is we should gather all possible ideas and group them in one
project on GitHub [1], like I said in my previous email. It is critical to
make the code clean as much as possible in my opinion. It deserves one
dedicated project to track all ideas. By doing this, the community can also
understand the current focuses are.
So my question is, should we init a project focusing on clean code, while
the purpose doesn't limit to grammar sugar?
Regards,
-Ian.
1. https://github.com/apache/incubator-dubbo/projects
On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <hb...@163.com> wrote:
> Hi, Huxing & LiZhen
>
> Things like diamond is something called grammar SUGAR.
> Tasted good for developers but the same on byte code.
>
> So in my opinion we should not take it as a kind of "policy correct".
> we can make the changes in the code of recent PRs but not for all the
> code. Think about there may be more sugars in future JVM.
>
> best regards,
>
> Jason
>
> > On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
> >
> > Your pr has modified more than 30,000 lines of code, and most of them are
> > modifications of the entire file.
> > What is the meaning of your pr? Why do I need to keep it open?
> >
> > If you need to discuss, issues and mailing lists are good choices, why do
> > you need to discuss pr?
> >
> > Who can review this pr[1] and tell me what this pr is going to do?
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/3371
> >
> > LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> >
> >> Yes, we can create a project to manage it, and we can talk about it.
> like:
> >> Should we used Diamond Operator replace explicit type? Use Lambda?
> >> Let's discuss the two pull requests above instead of closed it
> immediately.
> >>
> >>
> >>
> >>
> >>
> >> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> >>
> >>> Hi,
> >>>
> >>> Nice suggestion!
> >>>
> >>> Shall we can create a project to manage it?
> >>>
> >>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> >> wrote:
> >>>>
> >>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> >> unused
> >>>> methods ,unused logic , nonstandard naming in the code. And there are
> >>> some
> >>>> code that can use the new features of java to make the code more
> >> concise
> >>>> and understandable. like Lambda , Diamond Operator and so on.These are
> >>> easy
> >>>> to find and fixed because of the tips of the idea .We should do it
> >> before
> >>>> completing the incubation.
> >>>
> >>>
> >>>
> >>> --
> >>> Best Regards！
> >>> Huxing
> >>>
> >>
>
>
Re: [Discuss] About Clean Code Plan
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <hb...@163.com> wrote:
>
> Hi, Huxing & LiZhen
>
> Things like diamond is something called grammar SUGAR.
> Tasted good for developers but the same on byte code.
>
> So in my opinion we should not take it as a kind of "policy correct".
> we can make the changes in the code of recent PRs but not for all the code. Think about there may be more sugars in future JVM.
I think any changes should be "reviewable".
I don't think we can change all the things in one pull request.
Instead, we should divide it into small ones and make it easy to be reviewed.
Recently I've seen several pull requests doing things like this. I
think they are very good examples.
>
> best regards,
>
> Jason
>
> > On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
> >
> > Your pr has modified more than 30,000 lines of code, and most of them are
> > modifications of the entire file.
> > What is the meaning of your pr? Why do I need to keep it open?
> >
> > If you need to discuss, issues and mailing lists are good choices, why do
> > you need to discuss pr?
> >
> > Who can review this pr[1] and tell me what this pr is going to do?
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/3371
> >
> > LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> >
> >> Yes, we can create a project to manage it, and we can talk about it. like:
> >> Should we used Diamond Operator replace explicit type? Use Lambda?
> >> Let's discuss the two pull requests above instead of closed it immediately.
> >>
> >>
> >>
> >>
> >>
> >> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> >>
> >>> Hi,
> >>>
> >>> Nice suggestion!
> >>>
> >>> Shall we can create a project to manage it?
> >>>
> >>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> >> wrote:
> >>>>
> >>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> >> unused
> >>>> methods ,unused logic , nonstandard naming in the code. And there are
> >>> some
> >>>> code that can use the new features of java to make the code more
> >> concise
> >>>> and understandable. like Lambda , Diamond Operator and so on.These are
> >>> easy
> >>>> to find and fixed because of the tips of the idea .We should do it
> >> before
> >>>> completing the incubation.
> >>>
> >>>
> >>>
> >>> --
> >>> Best Regards！
> >>> Huxing
> >>>
> >>
>
--
Best Regards！
Huxing
Re: [Discuss] About Clean Code Plan
Posted by Jason Joo <hb...@163.com>.
Hi, Huxing & LiZhen
Things like diamond is something called grammar SUGAR.
Tasted good for developers but the same on byte code.
So in my opinion we should not take it as a kind of "policy correct".
we can make the changes in the code of recent PRs but not for all the code. Think about there may be more sugars in future JVM.
best regards,
Jason
> On Jan 29, 2019, at 10:42, yuhang xiu <ca...@gmail.com> wrote:
>
> Your pr has modified more than 30,000 lines of code, and most of them are
> modifications of the entire file.
> What is the meaning of your pr? Why do I need to keep it open?
>
> If you need to discuss, issues and mailing lists are good choices, why do
> you need to discuss pr?
>
> Who can review this pr[1] and tell me what this pr is going to do?
>
> [1] https://github.com/apache/incubator-dubbo/pull/3371
>
> LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
>
>> Yes, we can create a project to manage it, and we can talk about it. like:
>> Should we used Diamond Operator replace explicit type? Use Lambda?
>> Let's discuss the two pull requests above instead of closed it immediately.
>>
>>
>>
>>
>>
>> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
>>
>>> Hi,
>>>
>>> Nice suggestion!
>>>
>>> Shall we can create a project to manage it?
>>>
>>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
>> wrote:
>>>>
>>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
>> unused
>>>> methods ,unused logic , nonstandard naming in the code. And there are
>>> some
>>>> code that can use the new features of java to make the code more
>> concise
>>>> and understandable. like Lambda , Diamond Operator and so on.These are
>>> easy
>>>> to find and fixed because of the tips of the idea .We should do it
>> before
>>>> completing the incubation.
>>>
>>>
>>>
>>> --
>>> Best Regards！
>>> Huxing
>>>
>>
Re: [Discuss] About Clean Code Plan
Posted by yuhang xiu <ca...@gmail.com>.
Your pr has modified more than 30,000 lines of code, and most of them are
modifications of the entire file.
What is the meaning of your pr? Why do I need to keep it open?
If you need to discuss, issues and mailing lists are good choices, why do
you need to discuss pr?
Who can review this pr[1] and tell me what this pr is going to do?
[1] https://github.com/apache/incubator-dubbo/pull/3371
LiZhenNet <li...@gmail.com> 于2019年1月29日周二 上午10:29写道：
> Yes, we can create a project to manage it, and we can talk about it. like:
> Should we used Diamond Operator replace explicit type? Use Lambda?
> Let's discuss the two pull requests above instead of closed it immediately.
>
>
>
>
>
> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
>
> > Hi,
> >
> > Nice suggestion!
> >
> > Shall we can create a project to manage it?
> >
> > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com>
> wrote:
> > >
> > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> unused
> > > methods ,unused logic , nonstandard naming in the code. And there are
> > some
> > > code that can use the new features of java to make the code more
> concise
> > > and understandable. like Lambda , Diamond Operator and so on.These are
> > easy
> > > to find and fixed because of the tips of the idea .We should do it
> before
> > > completing the incubation.
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
>
Re: [Discuss] About Clean Code Plan
Posted by LiZhenNet <li...@gmail.com>.
Yes, we can create a project to manage it, and we can talk about it. like:
Should we used Diamond Operator replace explicit type? Use Lambda?
Let's discuss the two pull requests above instead of closed it immediately.
Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 上午9:58写道：
> Hi,
>
> Nice suggestion!
>
> Shall we can create a project to manage it?
>
> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com> wrote:
> >
> > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> > methods ,unused logic , nonstandard naming in the code. And there are
> some
> > code that can use the new features of java to make the code more concise
> > and understandable. like Lambda , Diamond Operator and so on.These are
> easy
> > to find and fixed because of the tips of the idea .We should do it before
> > completing the incubation.
>
>
>
> --
> Best Regards！
> Huxing
>
Re: [Discuss] About Clean Code Plan
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
Nice suggestion!
Shall we can create a project to manage it?
On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com> wrote:
>
> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming in the code. And there are some
> code that can use the new features of java to make the code more concise
> and understandable. like Lambda , Diamond Operator and so on.These are easy
> to find and fixed because of the tips of the idea .We should do it before
> completing the incubation.
--
Best Regards！
Huxing
Re: [Discuss] About Clean Code Plan
Posted by Xin Wang <xi...@gmail.com>.
+1 to support use the new features , but test case should be added to
ensure the functions
LiZhenNet <li...@gmail.com> 于2019年1月25日周五 上午11:46写道：
> In addition ,There are too many duplicate codes in source code.
> And I will do some work at this weekend about this plan.
>
> Kun Song <so...@gmail.com> 于2019年1月25日周五 上午11:43写道：
>
> > Since 2.7 Java 8 is supported，anyone can use it now.
> >
> > 发自我的 iPhone
> >
> > > 在 2019年1月25日，上午11:24，LiZhenNet <li...@gmail.com> 写道：
> > >
> > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> unused
> > > methods ,unused logic , nonstandard naming in the code. And there are
> > some
> > > code that can use the new features of java to make the code more
> concise
> > > and understandable. like Lambda , Diamond Operator and so on.These are
> > easy
> > > to find and fixed because of the tips of the idea .We should do it
> before
> > > completing the incubation.
> >
>
Re: [Discuss] About Clean Code Plan
Posted by LiZhenNet <li...@gmail.com>.
In addition ,There are too many duplicate codes in source code.
And I will do some work at this weekend about this plan.
Kun Song <so...@gmail.com> 于2019年1月25日周五 上午11:43写道：
> Since 2.7 Java 8 is supported，anyone can use it now.
>
> 发自我的 iPhone
>
> > 在 2019年1月25日，上午11:24，LiZhenNet <li...@gmail.com> 写道：
> >
> > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> > methods ,unused logic , nonstandard naming in the code. And there are
> some
> > code that can use the new features of java to make the code more concise
> > and understandable. like Lambda , Diamond Operator and so on.These are
> easy
> > to find and fixed because of the tips of the idea .We should do it before
> > completing the incubation.
>
Re: [Discuss] About Clean Code Plan
Posted by Kun Song <so...@gmail.com>.
Since 2.7 Java 8 is supported，anyone can use it now.
发自我的 iPhone
> 在 2019年1月25日，上午11:24，LiZhenNet <li...@gmail.com> 写道：
>
> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming in the code. And there are some
> code that can use the new features of java to make the code more concise
> and understandable. like Lambda , Diamond Operator and so on.These are easy
> to find and fixed because of the tips of the idea .We should do it before
> completing the incubation.
Re: [Discuss] About Clean Code Plan
Posted by Ian Luo <ia...@gmail.com>.
good idea. It'd be even better if you could group all ideas backed by
issues into a dedicated project.
Thanks,
-Ian.
On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <li...@gmail.com> wrote:
> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming in the code. And there are some
> code that can use the new features of java to make the code more concise
> and understandable. like Lambda , Diamond Operator and so on.These are easy
> to find and fixed because of the tips of the idea .We should do it before
> completing the incubation.
>
Re: Re: [Discuss] About Clean Code Plan
Posted by LiZhenNet <li...@gmail.com>.
@beiwei, @yuhang
1. https://github.com/apache/incubator-dubbo/pull/3344
SkipFailbackWrapperException is added at 2012-07-13 , but never used ,I
think it should be added when it is needed。
2.https://github.com/apache/incubator-dubbo/pull/3371
Diamond Operator is a feature in jdk7.
KimmKing <ki...@apache.org> 于2019年1月26日周六 上午1:51写道：
>
>
>
> >> like Lambda , Diamond Operator
>
>
> Since dubbo only support jdk8+, it should be an important task for us.
>
>
>
>
> At 2019-01-25 12:18:56, "zhi_guang_liu@163.com" <zh...@163.com>
> wrote:
>
> |
> +1
> Agree with youre opinion!
>
>
> 您的朋友：刘志广
>
>
>
> From: LiZhenNet
> Date: 2019-01-25 11:24
> To: dev
> Subject: [Discuss] About Clean Code Plan
> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming in the code. And there are some
> code that can use the new features of java to make the code more concise
> and understandable. like Lambda , Diamond Operator and so on.These are easy
> to find and fixed because of the tips of the idea .We should do it before
> completing the incubation.
> |
Re:Re: [Discuss] About Clean Code Plan
Posted by KimmKing <ki...@apache.org>.
>> like Lambda , Diamond Operator
Since dubbo only support jdk8+, it should be an important task for us.
At 2019-01-25 12:18:56, "zhi_guang_liu@163.com" <zh...@163.com> wrote:
|
+1
Agree with youre opinion!
您的朋友：刘志广
From: LiZhenNet
Date: 2019-01-25 11:24
To: dev
Subject: [Discuss] About Clean Code Plan
Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
methods ,unused logic , nonstandard naming in the code. And there are some
code that can use the new features of java to make the code more concise
and understandable. like Lambda , Diamond Operator and so on.These are easy
to find and fixed because of the tips of the idea .We should do it before
completing the incubation.
|
Re: [Discuss] About Clean Code Plan
Posted by "zhi_guang_liu@163.com" <zh...@163.com>.
+1
Agree with youre opinion!
您的朋友：刘志广
From: LiZhenNet
Date: 2019-01-25 11:24
To: dev
Subject: [Discuss] About Clean Code Plan
Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
methods ,unused logic , nonstandard naming in the code. And there are some
code that can use the new features of java to make the code more concise
and understandable. like Lambda , Diamond Operator and so on.These are easy
to find and fixed because of the tips of the idea .We should do it before
completing the incubation.
Re: [Discuss] About Clean Code Plan
Posted by 徐靖峰 <ki...@foxmail.com>.
+1, lots of source code can be easy to refactor using IDEA. Such as lambda diamond operator, JDK8’s feature is welcome in Dubbo 2.7.
> 在 2019年1月25日，上午11:24，LiZhenNet <li...@gmail.com> 写道：
>
> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming in the code. And there are some
> code that can use the new features of java to make the code more concise
> and understandable. like Lambda , Diamond Operator and so on.These are easy
> to find and fixed because of the tips of the idea .We should do it before
> completing the incubation.