You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by David Sidrane <Da...@nscdg.com> on 2019/12/21 11:47:26 UTC

[PATCH] imxrt fixes FW: [apache/incubator-nuttx] imxrt fixes (#1)

PATCH is here
https://patch-diff.githubusercontent.com/raw/apache/incubator-nuttx/pull/1.patch



PR is here https://github.com/apache/incubator-nuttx/pull/1







*From:* David Sidrane [mailto:notifications@github.com]
*Sent:* Saturday, December 21, 2019 3:42 AM
*To:* apache/incubator-nuttx
*Cc:* David Sidrane; Your activity
*Subject:* [apache/incubator-nuttx] imxrt fixes (#1)



In bringing up the NXP RDDRONE-FMURT6 these issues were discovered and
fixed.

·         False detection

·         No Detection I2C

·         System lock up hang due to interrupt storm

Prior to this PR

NuttShell (NSH)

nsh>  i2cdetect -b 1

Scanning I2C bus: 1

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f

00: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

70: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

nsh>  i2cdetect -b 2

Scanning I2C bus: 2

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f

00: 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d <HUNG>

Top Traces are the I2C IRQ, SPI IRQ and CPU IRQ,
Big Picture
[image: image]
<https://user-images.githubusercontent.com/1945821/71307341-c0d34700-23a1-11ea-8c5c-14727fceb0cd.png>
Focus on Storm
[image: image]
<https://user-images.githubusercontent.com/1945821/71307356-0263f200-23a2-11ea-8557-a49962a2dd3a.png>
The Storme rate.
[image: image]
<https://user-images.githubusercontent.com/1945821/71307363-1e679380-23a2-11ea-862f-0dd36cc39b21.png>

With this PR

NuttShell (NSH)

nsh>  i2cdetect -b 1

Scanning I2C bus: 1

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f

00: -- -- -- -- -- -- -- -- -- -- -- -- -- -- 0e --

10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

50: -- -- -- -- -- 55 -- -- -- -- -- -- -- -- -- --

60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

70: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

nsh>  i2cdetect -b 2

Scanning I2C bus: 2

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f

00: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- 1e --

20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

70: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

[image: image]
<https://user-images.githubusercontent.com/1945821/71307465-c3cf3700-23a3-11ea-91ad-d1e61b45ea53.png>
------------------------------
You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-nuttx/pull/1
Commit Summary

·         imxrt:gpio Support readback on OUT GPIO

·         imxrt:lpi2c imxrt_lpi2c_reset uses GPIO with SION

·         imxrt:lpi2c ensure that on an error status reflects it.

·         imxrt:lpi2c Fix interrupt storm on failed write.

·         imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix
GPIO_GPT1_CAPTURE[1|2]
File Changes

·         *M* arch/arm/src/imxrt/hardware/rt106x/imxrt106x_pinmux.h
<https://github.com/apache/incubator-nuttx/pull/1/files#diff-0> (5)

·         *M* arch/arm/src/imxrt/imxrt_gpio.c
<https://github.com/apache/incubator-nuttx/pull/1/files#diff-1> (66)

·         *M* arch/arm/src/imxrt/imxrt_lpi2c.c
<https://github.com/apache/incubator-nuttx/pull/1/files#diff-2> (220)
Patch Links:

·         https://github.com/apache/incubator-nuttx/pull/1.patch

·         https://github.com/apache/incubator-nuttx/pull/1.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/apache/incubator-nuttx/pull/1?email_source=notifications&email_token=AAO3BXOYD5KZJGGP5GB2ADLQZX6HHA5CNFSM4J6GW33KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICD3JZA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO3BXK6MYSJ5NMZKDENOKTQZX6HHANCNFSM4J6GW33A>
.

Re: [PATCH] imxrt fixes FW: [apache/incubator-nuttx] imxrt fixes (#1)

Posted by Gregory Nutt <sp...@gmail.com>.
> PATCH is here
> https://patch-diff.githubusercontent.com/raw/apache/incubator-nuttx/pull/1.patch
>
>
>
> PR is here https://github.com/apache/incubator-nuttx/pull/1

I am finished.  I will not review any further changes or make any 
further commits

Greg