[jira] [Commented] (WICKET-4493) Unwrapped IllegalArgumentException in WicketURLDecoder

["Johan Heylen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468409#comment-13468409 ] 

Johan Heylen commented on WICKET-4493:
--------------------------------------

Martin, sorry for commenting on a closed issue,

can you elaborate your comment about this not being an issue in 1.5.x?

If I use a page param with a wrong usage of the % sign which yields into a IllegalArgumentException, this resolves in a http 500 error and my servlet container (jetty,tomcat) uses the web.xml configured     
<error-page>
  <error-code>500</error-code>
  <location>...</location>
</error-page>

Or should I use the getExceptionSettings().setUnexpectedExceptionDisplay(IExceptionSettings.SHOW_INTERNAL_ERROR_PAGE) to let Wicket handle the exception?
                
> Unwrapped IllegalArgumentException in WicketURLDecoder
> ------------------------------------------------------
>
>                 Key: WICKET-4493
>                 URL: https://issues.apache.org/jira/browse/WICKET-4493
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket
>    Affects Versions: 1.4.19
>            Reporter: James McIntosh
>            Priority: Minor
>
> In the class: org.apache.wicket.protocol.http.WicketURLDecoder there are two IllegalArgumentException which should be wrapped in WicketRuntimeException
> Wrapping them would be good for consistency and help manage runtime exceptions.
> These are the two exceptions, lines 164 and 179:
> throw new IllegalArgumentException("URLDecoder: Incomplete trailing escape (%) pattern");
> throw new IllegalArgumentException("URLDecoder: Illegal hex characters in escape (%) pattern - " + e.getMessage());
> e.g.
> throw new WicketRuntimeException(new IllegalArgumentException("URLDecoder: Incomplete trailing escape (%) pattern"));
> throw new WicketRuntimeException(new IllegalArgumentException("URLDecoder: Illegal hex characters in escape (%) pattern - " + e.getMessage()));
> Other similar runtime exceptions found:
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest
> Lines 106, 114
> throw new IllegalArgumentException("argument maxSize must be not null");
> throw new IllegalStateException("ServletRequest does not contain multipart content. One possible solution is to explicitly call Form.setMultipart(true), Wicket tries its best to auto-detect multipart forms but there are certain situation where it cannot.");

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira