You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joel Koshy <jj...@gmail.com> on 2014/04/21 23:34:30 UTC
Review Request 20536: Patch for KAFKA-1380
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20536/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1380
https://issues.apache.org/jira/browse/KAFKA-1380
Repository: kafka
Description
-------
KAFKA-1356; follow-up - return unknown topic partition on non-existent topic if auto.create is off
Diffs
-----
core/src/main/scala/kafka/server/KafkaApis.scala 9e569eb8c3586b2fdb3b5904c5fa5f938cffada1
Diff: https://reviews.apache.org/r/20536/diff/
Testing
-------
Thanks,
Joel Koshy
Re: Review Request 20536: Patch for KAFKA-1380
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20536/#review40961
-----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/20536/#comment74285>
Actually bad patch - I meant to remove the check from above. I'll update patch.
- Joel Koshy
On April 21, 2014, 9:34 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20536/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 9:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1380
> https://issues.apache.org/jira/browse/KAFKA-1380
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1356; follow-up - return unknown topic partition on non-existent topic if auto.create is off
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 9e569eb8c3586b2fdb3b5904c5fa5f938cffada1
>
> Diff: https://reviews.apache.org/r/20536/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 20536: Patch for KAFKA-1380
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20536/#review40962
-----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/20536/#comment74286>
it seems this might be unreachable for the auto create disabled case.
- Neha Narkhede
On April 21, 2014, 9:34 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20536/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 9:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1380
> https://issues.apache.org/jira/browse/KAFKA-1380
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1356; follow-up - return unknown topic partition on non-existent topic if auto.create is off
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 9e569eb8c3586b2fdb3b5904c5fa5f938cffada1
>
> Diff: https://reviews.apache.org/r/20536/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 20536: Patch for KAFKA-1380
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20536/#review40959
-----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/20536/#comment74283>
Isn't this a unnecessary check? The parent if check already checks the flag.
- Timothy Chen
On April 21, 2014, 9:34 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20536/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 9:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1380
> https://issues.apache.org/jira/browse/KAFKA-1380
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1356; follow-up - return unknown topic partition on non-existent topic if auto.create is off
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 9e569eb8c3586b2fdb3b5904c5fa5f938cffada1
>
> Diff: https://reviews.apache.org/r/20536/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 20536: Patch for KAFKA-1380
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20536/#review40967
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On April 21, 2014, 9:48 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20536/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 9:48 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1380
> https://issues.apache.org/jira/browse/KAFKA-1380
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1356; follow-up - return unknown topic partition on non-existent topic if auto.create is off
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 9e569eb8c3586b2fdb3b5904c5fa5f938cffada1
>
> Diff: https://reviews.apache.org/r/20536/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 20536: Patch for KAFKA-1380
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20536/
-----------------------------------------------------------
(Updated April 21, 2014, 9:48 p.m.)
Review request for kafka.
Bugs: KAFKA-1380
https://issues.apache.org/jira/browse/KAFKA-1380
Repository: kafka
Description
-------
KAFKA-1356; follow-up - return unknown topic partition on non-existent topic if auto.create is off
Diffs (updated)
-----
core/src/main/scala/kafka/server/KafkaApis.scala 9e569eb8c3586b2fdb3b5904c5fa5f938cffada1
Diff: https://reviews.apache.org/r/20536/diff/
Testing
-------
Thanks,
Joel Koshy