[jira] [Commented] (WSS-356) Investigate signing Crypto differences

["Marc Giger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WSS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493070#comment-13493070 ] 

Marc Giger commented on WSS-356:
--------------------------------

Hi Colm,

Do you mean the issuer crypto instance which is passed via SAMLCallback?:

assertion.signAssertion(
                samlCallback.getIssuerKeyName(),
                samlCallback.getIssuerKeyPassword(), 
                samlCallback.getIssuerCrypto(),
                samlCallback.isSendKeyValue()
            );

My opinion is that we should leave it as it is for maximum flexibility and for "separation of concerns".
But I don't really mind...

Marc
                
> Investigate signing Crypto differences
> --------------------------------------
>
>                 Key: WSS-356
>                 URL: https://issues.apache.org/jira/browse/WSS-356
>             Project: WSS4J
>          Issue Type: Sub-task
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>             Fix For: 2.0
>
>
> Is there really a need to have a separate Crypto instance to sign SAML Assertions? Maybe we should just use the signature Crypto instance for this instead?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org