You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/26 17:44:44 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #9207:
Switching to Inter & Fira typefaces
rusackas opened a new pull request #9207: Switching to Inter & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR updates the main UI typeface of Superset to [Inter UI](https://github.com/rsms/inter), and code fonts (e.g. SQL editor) to [Fira Mono](https://github.com/mozilla/Fira) or [Fira Code](https://github.com/tonsky/FiraCode). All three fonts are under the SIL Open Font License, and license information has been added to `LICENSE.txt` to reflect this, as per [ASF guidelines](https://www.apache.org/legal/resolved.html).
This work is a small step toward SIP-34 (#8976).
Note that the Roboto font (not actually used visibly anywhere) was also removed, in both its binaries and `LICENSE.txt` references.
Fira Code is a font that contains handy ligatures that many people love. However, not everyone might love them, so there's a LESS variable called `@use-ligatures` to turn them on or off (they're off by default). If/when we move to a CSS-in-JS approach (See SIP-37, issue #9123), we can make this selection more dynamic, switchable via user preference or deployment config.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Coming soon...
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@etr2460 @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #9207: Introducing
Inter UI & Fira typefaces
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9207: Introducing Inter UI & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207#issuecomment-594693958
> Is there a plan for updating fonts on the charts? like mass migrating to set `font: inherit` or something?
@williaster My initial thought, for the shorter term, is to just add the new fonts by name to the front of the font stack. Using "inherit" might also work, but could also have ramifications in other (embeded) use cases. By explicitly naming the font, the charts would fall back to their existing font stack when the new font is not available for whatever reason.
Longer term, I think the plugins should follow the CSS-in-JS patterns we use for the main repo, and ultimately pull from the same `theme` settings (presumably pulled in from Superset-UI). SIP-37 is in need of votes to make that a possibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #9207: Introducing
Inter UI & Fira typefaces
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9207: Introducing Inter UI & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #9207: Introducing
Inter UI & Fira typefaces
Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9207: Introducing Inter UI & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207#issuecomment-593708451
ooh, that's good to know. i think this looks fine from my perspective then. Let's make sure we have an action item going forward to standardize on font weights within our less variables file then so that we don't get a weird mix of different types of font stylings (i still think there might be value in limiting the files committed in the repo so no one accidentally uses uncommon font weights, but it's not too big of a deal)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9207:
Introducing Inter UI & Fira typefaces
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9207: Introducing Inter UI & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207#issuecomment-592093024
Yaaaaaayyyyy ligature support!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull
request #9207: Introducing Inter UI & Fira typefaces
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9207: Introducing Inter UI & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207#discussion_r388049288
##########
File path: LICENSE.txt
##########
@@ -208,9 +208,9 @@ limitations under the License.
subcomponents is subject to the terms and conditions of the following
licenses.
-
========================================================================
-Third party Apache 2.0 licenses
+Third party SIL Open Font License v1.1 (OFL-1.1)
Review comment:
Are we sure SIL is apache-comptible? Listed here as "weak copyleft"
https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] williaster commented on issue #9207:
Introducing Inter UI & Fira typefaces
Posted by GitBox <gi...@apache.org>.
williaster commented on issue #9207: Introducing Inter UI & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207#issuecomment-594178687
Is there a plan for updating fonts on the charts? like mass migrating to set `font: inherit` or something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #9207: Introducing
Inter UI & Fira typefaces
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9207: Introducing Inter UI & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207#issuecomment-593704224
@etr2460 I shared this concern as I was implementing this... in fact I went down a rabbit hole of writing LESS conditional mixins to only load the `@font-face`s that were actually in use. In the end though, it turns out every browser since IE8 is smart enough to NOT load `@font-face` resources that aren't actually in use. So, I added all the font binaries to the repo in case they come in handy, but in actuality, only three of the weights, and one of the formats, might ever actually get loaded. Usually only a couple of those are actually in use by a given view, and they do appear to be cached from what I saw. So despite all the font binaries visible in this PR, the burden on load is actually pretty light.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull
request #9207: Introducing Inter UI & Fira typefaces
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9207: Introducing Inter UI & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207#discussion_r388049288
##########
File path: LICENSE.txt
##########
@@ -208,9 +208,9 @@ limitations under the License.
subcomponents is subject to the terms and conditions of the following
licenses.
-
========================================================================
-Third party Apache 2.0 licenses
+Third party SIL Open Font License v1.1 (OFL-1.1)
Review comment:
Are we sure SIL is apache-comptible? https://www.apache.org/legal/resolved.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org