You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/20 10:48:20 UTC
[GitHub] [dolphinscheduler] ZhongJinHacker opened a new issue, #13232: [Improvement][Master] Find a word spell error and a comment location error
ZhongJinHacker opened a new issue, #13232:
URL: https://github.com/apache/dolphinscheduler/issues/13232
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
I find a word spell error in WorkflowExecuteRunnable.java when i read the source code.
the 'weakup' may be a incorrect word, it may mislead people
<img width="974" alt="截屏2022-12-20 18 40 57" src="https://user-images.githubusercontent.com/15382560/208647796-3e37daa3-7ddf-4844-853c-9d74086aee9b.png">
and a comment in follow picture is not express the code block, I think it must move to the 'else' block, it describe the else block's logic
<img width="1071" alt="截屏2022-12-20 18 47 01" src="https://user-images.githubusercontent.com/15382560/208649155-0d2041b9-0176-4158-be55-aff6d7cd3e94.png">
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13232: [Improvement][Master] Find a word spell error and a comment location error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13232:
URL: https://github.com/apache/dolphinscheduler/issues/13232#issuecomment-1359169442
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng closed issue #13232: [Improvement][Master] Find a word spell error and a comment location error
Posted by GitBox <gi...@apache.org>.
caishunfeng closed issue #13232: [Improvement][Master] Find a word spell error and a comment location error
URL: https://github.com/apache/dolphinscheduler/issues/13232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13232: [Improvement][Master] Find a word spell error and a comment location error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13232:
URL: https://github.com/apache/dolphinscheduler/issues/13232#issuecomment-1359169177
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
I find a word spell error in WorkflowExecuteRunnable.java when i read the source code.
the 'weakup' may be a incorrect word, it may mislead people
<img width="974" alt="截屏2022-12-20 18 40 57" src="https://user-images.githubusercontent.com/15382560/208647796-3e37daa3-7ddf-4844-853c-9d74086aee9b.png">
and a comment in follow picture is not express the code block, I think it must move to the 'else' block, it describe the else block's logic
<img width="1071" alt="截屏2022-12-20 18 47 01" src="https://user-images.githubusercontent.com/15382560/208649155-0d2041b9-0176-4158-be55-aff6d7cd3e94.png">
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org