[GitHub] [ignite-extensions] alex-plekhanov commented on a diff in pull request #139: IGNITE-16968 Fix the sources directory for extension release

[GitBox <gi...@apache.org>]

alex-plekhanov commented on code in PR #139:
URL: https://github.com/apache/ignite-extensions/pull/139#discussion_r871689168


##########
modules/aws-ext/README.txt:
##########
@@ -6,7 +6,7 @@ Apache Ignite AWS module provides S3-based implementations of checkpoint SPI and
 Depending on how you use Ignite, you can an extension using one of the following methods:
 
 - If you use the binary distribution, move the lib/optional/{module-dir} to the lib directory before starting the node.
-- Add libraries from lib/optional/{module-dir} to the classpath of your application.
+- Add libraries from lib/{module-dir} to the classpath of your application.

Review Comment:
   There is no `lib/{module-dir}` directory in the assembly, all files are inside `lib` directory.
   Also, `If you use the binary distribution, move the lib/optional/{module-dir} to the lib directory before starting the node.` should be fixed too.



##########
DEVNOTES.md:
##########
@@ -4,22 +4,30 @@
 
 ## Build Instructions
 
+### Build Requirements
+
+- JDK 8
+- Maven 3.6.3+
+
 ### Build all Extensions
 
 ```shell
+# Run from the Ignite Extension project root
 mvn clean install -DskipTests -Pcheckstyle
 ```
 
 ### Build an Extension
 
 ```shell
-mvn clean install -f modules/sptring-boot-ext -Pcheckstyle
+# Run from the Ignite Extension project root
+mvn clean install -f modules/sptring-boot-ext -Pcheckstyle -DskipTests

Review Comment:
   `sptring-boot-ext` -> `spring-boot-ext`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org