You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/07/24 09:48:38 UTC

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1411: Zookeeper 3112: fd leak due to UnresolvedAddressException on connect.

eolivelli commented on a change in pull request #1411:
URL: https://github.com/apache/zookeeper/pull/1411#discussion_r459956475



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNIO.java
##########
@@ -289,6 +289,10 @@ void connect(InetSocketAddress addr) throws IOException {
             LOG.error("Unable to open socket to " + addr);
             sock.close();
             throw e;
+        } catch (RuntimeException e) {
+            LOG.error("Unable to open socket to " + addr);

Review comment:
       This code looks like the code above.
   Can we use multicatch syntax?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org