You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/11 05:26:48 UTC

[GitHub] [incubator-mxnet] josephevans opened a new pull request #19882: [v1.x] For ECR, ensure we sanitize region input from environment variable

josephevans opened a new pull request #19882:
URL: https://github.com/apache/incubator-mxnet/pull/19882


   ## Description ##
   * Sanitize the region input that we extract from an environment variable to prevent command injection. 
   * Set a default value for recently introduced cache_intermediate.
   * If using ECR, don't throw an exception if dockerhub environment variables are not set
   * Track ECR login using a global variable, so we only have to retrieve login credentials once


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19882: [v1.x] For ECR, ensure we sanitize region input from environment variable

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19882:
URL: https://github.com/apache/incubator-mxnet/pull/19882#issuecomment-777210708


   Hey @josephevans , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [website, unix-cpu, centos-gpu, sanity, windows-gpu, edge, miscellaneous, windows-cpu, unix-gpu, centos-cpu, clang]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #19882: [v1.x] For ECR, ensure we sanitize region input from environment variable

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy merged pull request #19882:
URL: https://github.com/apache/incubator-mxnet/pull/19882


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org