You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tapestry.apache.org by "Steve Eynon (Created) (JIRA)" <ji...@apache.org> on 2011/10/19 17:45:10 UTC

[jira] [Created] (TAP5-1706) JS syntax error in Tapestry.ajaxRequest() when Ajax fails

JS syntax error in Tapestry.ajaxRequest() when Ajax fails
---------------------------------------------------------

                 Key: TAP5-1706
                 URL: https://issues.apache.org/jira/browse/TAP5-1706
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.3, 5.2.6
            Reporter: Steve Eynon
            Priority: Minor


In tapestry.js the JS Tapestry.ajaxRequest() method accesses the finalOptions variable incorrectly. 

It is a prototype $H Hash, not an array, and so must be accessed as such:

    finalOptions.toObject().onFailure.call(this, response);

and not

 finalOptions.onFailure.call(this, response);

Attached is a patch for this...

...although looking at the docs - http://api.prototypejs.org/language/dollar-H/ - a more optimal approach may be

    finalOptions.get('onFailure').call(this, response);



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (TAP5-1706) JS syntax error in Tapestry.ajaxRequest() when Ajax fails

Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/TAP5-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1706.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3
         Assignee: Howard M. Lewis Ship
    
> JS syntax error in Tapestry.ajaxRequest() when Ajax fails
> ---------------------------------------------------------
>
>                 Key: TAP5-1706
>                 URL: https://issues.apache.org/jira/browse/TAP5-1706
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2.6
>            Reporter: Steve Eynon
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>         Attachments: t5-js-patch.txt
>
>
> In tapestry.js the JS Tapestry.ajaxRequest() method accesses the finalOptions variable incorrectly. 
> It is a prototype $H Hash, not an array, and so must be accessed as such:
>     finalOptions.toObject().onFailure.call(this, response);
> and not
>  finalOptions.onFailure.call(this, response);
> Attached is a patch for this...
> ...although looking at the docs - http://api.prototypejs.org/language/dollar-H/ - a more optimal approach may be
>     finalOptions.get('onFailure').call(this, response);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-1706) JS syntax error in Tapestry.ajaxRequest() when Ajax fails

Posted by "Steve Eynon (Updated) (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/TAP5-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Eynon updated TAP5-1706:
------------------------------

    Attachment: t5-js-patch.txt

The patch for tapestry.js
                
> JS syntax error in Tapestry.ajaxRequest() when Ajax fails
> ---------------------------------------------------------
>
>                 Key: TAP5-1706
>                 URL: https://issues.apache.org/jira/browse/TAP5-1706
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2.6
>            Reporter: Steve Eynon
>            Priority: Minor
>         Attachments: t5-js-patch.txt
>
>
> In tapestry.js the JS Tapestry.ajaxRequest() method accesses the finalOptions variable incorrectly. 
> It is a prototype $H Hash, not an array, and so must be accessed as such:
>     finalOptions.toObject().onFailure.call(this, response);
> and not
>  finalOptions.onFailure.call(this, response);
> Attached is a patch for this...
> ...although looking at the docs - http://api.prototypejs.org/language/dollar-H/ - a more optimal approach may be
>     finalOptions.get('onFailure').call(this, response);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-1706) JS syntax error in Tapestry.ajaxRequest() when Ajax fails

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/TAP5-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130803#comment-13130803 ] 

Hudson commented on TAP5-1706:
------------------------------

Integrated in tapestry-trunk-freestyle #590 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/590/])
    TAP5-1706: JS syntax error in Tapestry.ajaxRequest() when Ajax fails

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186341
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js

                
> JS syntax error in Tapestry.ajaxRequest() when Ajax fails
> ---------------------------------------------------------
>
>                 Key: TAP5-1706
>                 URL: https://issues.apache.org/jira/browse/TAP5-1706
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2.6
>            Reporter: Steve Eynon
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>         Attachments: t5-js-patch.txt
>
>
> In tapestry.js the JS Tapestry.ajaxRequest() method accesses the finalOptions variable incorrectly. 
> It is a prototype $H Hash, not an array, and so must be accessed as such:
>     finalOptions.toObject().onFailure.call(this, response);
> and not
>  finalOptions.onFailure.call(this, response);
> Attached is a patch for this...
> ...although looking at the docs - http://api.prototypejs.org/language/dollar-H/ - a more optimal approach may be
>     finalOptions.get('onFailure').call(this, response);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira