You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/01 22:11:39 UTC

[jira] [Commented] (DRILL-4069) Enable RPC Thread Offload by default

    [ https://issues.apache.org/jira/browse/DRILL-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127041#comment-15127041 ] 

ASF GitHub Bot commented on DRILL-4069:
---------------------------------------

GitHub user sudheeshkatkam opened a pull request:

    https://github.com/apache/drill/pull/352

    DRILL-4069: Enable RPC thread offload by default

    https://github.com/apache/drill/commit/43414e1e2731c85a52febaaedebfa2f392dd6d2f removes the usage of recyclers for RequestEvent and ResponseEvent in the RPC layer. This change resolves functional regressions mentioned in [DRILL-4041](https://issues.apache.org/jira/browse/DRILL-4041) and [DRILL-4057](https://issues.apache.org/jira/browse/DRILL-4057).
    
    Multiple test runs with the same setup mentioned in the tickets did not show any regressions.
    
    @jacques-n can you please review?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudheeshkatkam/drill DRILL-4069

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #352
    
----
commit f2d42074d64d2146eb15bee2374edf78864f832e
Author: Sudheesh Katkam <sk...@maprtech.com>
Date:   2016-01-22T21:12:50Z

    DRILL-4069: Enable RPC thread offload by default

----


> Enable RPC Thread Offload by default
> ------------------------------------
>
>                 Key: DRILL-4069
>                 URL: https://issues.apache.org/jira/browse/DRILL-4069
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - RPC
>            Reporter: Jacques Nadeau
>
> Once we enabled RPC thread offload, we saw concurrency regressions DRILL-4041 and DRILL-4057. The regressions appear to be unrelated to, but exposed by the thread offload. To simplify things, we disabled the RPC thread offload by default. This is the tracking issue to fix the underlying concurrency bug(s).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)