[GitHub] [skywalking] wu-sheng commented on a change in pull request #2771: Filtering pods not in 'Running' phase

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #2771: Filtering pods not in 'Running' phase
URL: https://github.com/apache/skywalking/pull/2771#discussion_r287956826
 
 

 ##########
 File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/K8sALSServiceMeshHTTPAnalysis.java
 ##########
 @@ -93,8 +95,13 @@ private void loadPodInfo() {
             Map<String, ServiceMetaInfo> ipMap = new HashMap<>(list.getItems().size());
             long startTime = System.nanoTime();
             for (V1Pod item : list.getItems()) {
+                if (!item.getStatus().getPhase().equals(VALID_PHASE)) {
 
 Review comment:
   Whether the status and phase are NULL? Cause NPE maybe.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services