You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "guixiaowen (via GitHub)" <gi...@apache.org> on 2024/05/09 03:58:29 UTC

[PR] [SPARK-48210][doc]Modify the description of whether dynamic partition… [spark]

guixiaowen opened a new pull request, #46496:
URL: https://github.com/apache/spark/pull/46496

   …ing is enabled in the “ Stage Level Scheduling Overview”
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'common/utils/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   “  Stage Level Scheduling Overview ” in running-on-yarn and  running-on-kubernetes
   
   The description of dynamic partitioning is inconsistent with the code implementation verification.
   
   In running-on-yarn 
   
   '
   
   When dynamic allocation is disabled: It allows users to specify different task resource requirements at the stage level and will use the same executors requested at startup.
   '
   
   But the  implementation is:
   
   Class:ResourceProfileManager
   
   Fuc:isSupported
   
   private[spark] def isSupported(rp: ResourceProfile): Boolean = {
   assert(master != null)
   if (rp.isInstanceOf[TaskResourceProfile] && !dynamicEnabled) {
   if ((notRunningUnitTests || testExceptionThrown) &&
   !(isStandaloneOrLocalCluster || isYarn || isK8s))
   
   { throw new SparkException("TaskResourceProfiles are only supported for Standalone, " + "Yarn and Kubernetes cluster for now when dynamic allocation is disabled.") }
   }
   
    
   
   The judgment of this code is that it does not support TaskResourceProfile in Yarn and k8s when dynamic partitioning is closed.
   
    
   
   The description in the document does not match, so the document needs to be modified.
   
    
   
   
   ### Why are the changes needed?
   This description is a bit misleading for users. 
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   <!--
   If generative AI tooling has been used in the process of authoring this patch, please include the
   phrase: 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][DOC]Modify the description of whether dynamic partition… [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #46496: [SPARK-48210][DOC]Modify the description of whether dynamic partition…
URL: https://github.com/apache/spark/pull/46496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][DOC]Modify the description of whether dynamic partition… [spark]

Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #46496:
URL: https://github.com/apache/spark/pull/46496#issuecomment-2119611968

   > what version of Spark are you using? That issue I pointed to was fixed in 4.0.0 and 3.5.1.
   > 
   > The check and error that is on the main branch should read:
   > 
   > ```
   >       if ((notRunningUnitTests || testExceptionThrown) &&
   >         !(isStandaloneOrLocalCluster || isYarn || isK8s)) {
   >         throw new SparkException("TaskResourceProfiles are only supported for Standalone, " +
   >           "Yarn and Kubernetes cluster for now when dynamic allocation is disabled.")
   > ```
   > 
   > https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/resource/ResourceProfileManager.scala#L73
   > 
   > I'm guessing you are using a version of Spark before that change.
   
   @tgravescs  
   I tested on 3.5.1 and main branch (4.0.0)
   The results of these two branch tests are the same. The code is restricted, but the documentation states that it is possible to enable it.
   This place is a bit contradictory


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][DOC]Modify the description of whether dynamic partition… [spark]

Posted by "amogkam (via GitHub)" <gi...@apache.org>.
amogkam commented on PR #46496:
URL: https://github.com/apache/spark/pull/46496#issuecomment-2257247815

   the exception being thrown is still in master https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/resource/ResourceProfileManager.scala#L90-L91
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][DOC]Modify the description of whether dynamic partition… [spark]

Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #46496:
URL: https://github.com/apache/spark/pull/46496#issuecomment-2105515304

   > sorry this description is very hard to read. I think you are trying to say that stage level scheduling isn't supported on k8s and yarn when dynamic allocation is disabled? When you say dynamic partitions do you mean dynamic allocation of executors?
   > 
   > That is not true we added support - https://issues.apache.org/jira/browse/SPARK-45495
   > 
   > The description as is:
   > 
   > > * When dynamic allocation is disabled: It allows users to specify different task resource requirements at the stage level and will use the same executors requested at startup.
   > 
   > Is correct. When dynamic allocation is off, you can specify a different resource profile that changes the task requiresments but uses the existing executors.
   
   @tgravescs  Thank you for your reply.
   
   Can you help me check my configuration, code, and error messages returned.
   
   Is there a problem with our understanding?
   
   
   set spark.dynamicAllocation.enabled=false
   
   `
   import  org.apache.spark.resource.ResourceProfileBuilder
   import  org.apache.spark.resource.TaskResourceRequests
   
   val rdd = sc.range(0, 9)
   val rpBuilder = new ResourceProfileBuilder()
   val taskReqs = new TaskResourceRequests().cpus(1)
   val rp = rpBuilder.require(taskReqs).build
   rdd.withResources(rp)
   `
   
   Return info:
   
   `
   org.apache.spark.SparkException: TaskResourceProfiles are only supported for Standalone cluster for now when dynamic allocation is disabled.
     at org.apache.spark.resource.ResourceProfileManager.isSupported(ResourceProfileManager.scala:71)
     at org.apache.spark.resource.ResourceProfileManager.addResourceProfile(ResourceProfileManager.scala:126)
     at org.apache.spark.rdd.RDD.withResources(RDD.scala:1829)
     ... 48 elided
   
   `
   According to the document description,  is  '**specify different task resource requirements** ' set TaskResourceRequests?
   
   ‘
   When dynamic allocation is disabled: It allows users to specify different task resource requirements at the stage level and will use the same executors requested at startup.
   ’
   
   Is there a problem with my understanding? 
   Can you help me answer this? Thank you.
   
   
   
    
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][DOC]Modify the description of whether dynamic partition… [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #46496:
URL: https://github.com/apache/spark/pull/46496#issuecomment-2103866076

   cc @mridulm and @tgravescs 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][DOC]Modify the description of whether dynamic partition… [spark]

Posted by "tgravescs (via GitHub)" <gi...@apache.org>.
tgravescs commented on PR #46496:
URL: https://github.com/apache/spark/pull/46496#issuecomment-2104707237

   sorry this description is very hard to read.  I think you are trying to say that stage level scheduling isn't supported on k8s and yarn when dynamic allocation is disabled?   When you say dynamic partitions do you mean dynamic allocation of executors?
   
   That is not true we added support - https://issues.apache.org/jira/browse/SPARK-45495
   
   The description as is:
   > - When dynamic allocation is disabled: It allows users to specify different task resource requirements at the stage level and will use the same executors requested at startup.
   
   Is correct. When dynamic allocation is off, you can specify a different resource profile that changes the task requiresments but uses the existing executors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][DOC]Modify the description of whether dynamic partition… [spark]

Posted by "tgravescs (via GitHub)" <gi...@apache.org>.
tgravescs commented on PR #46496:
URL: https://github.com/apache/spark/pull/46496#issuecomment-2117624849

   what version of Spark are you using?  That issue I pointed to was fixed in 4.0.0 and 3.5.1.
   
   The check and error that is on the main branch should read:
   
   ```
         if ((notRunningUnitTests || testExceptionThrown) &&
           !(isStandaloneOrLocalCluster || isYarn || isK8s)) {
           throw new SparkException("TaskResourceProfiles are only supported for Standalone, " +
             "Yarn and Kubernetes cluster for now when dynamic allocation is disabled.")
   ```
   
   https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/resource/ResourceProfileManager.scala#L73
   
   I'm guessing you are using a version of Spark before that change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][doc]Modify the description of whether dynamic partition… [spark]

Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #46496:
URL: https://github.com/apache/spark/pull/46496#issuecomment-2101889679

   @cloud-fan  hi, Can you help me review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][DOC]Modify the description of whether dynamic partition… [spark]

Posted by "amogkam (via GitHub)" <gi...@apache.org>.
amogkam commented on PR #46496:
URL: https://github.com/apache/spark/pull/46496#issuecomment-2257244720

   also running into this error with 3.5.1 when trying to use stage level scheduling with `dynamicAllocation` set to False
   
   ```
   : org.apache.spark.SparkException: ResourceProfiles are only supported on YARN and Kubernetes and Standalone with dynamic allocation enabled.
   	at org.apache.spark.resource.ResourceProfileManager.isSupported(ResourceProfileManager.scala:88)
   	at org.apache.spark.resource.ResourceProfileManager.addResourceProfile(ResourceProfileManager.scala:127)
   	at org.apache.spark.rdd.RDD.withResources(RDD.scala:1832)
   	at org.apache.spark.api.java.JavaRDD.withResources(JavaRDD.scala:59)
   	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   	at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
   	at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:374)
   	at py4j.Gateway.invoke(Gateway.java:282)
   	at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
   	at py4j.commands.CallCommand.execute(CallCommand.java:79)
   	at py4j.ClientServerConnection.waitForCommands(ClientServerConnection.java:182)
   	at py4j.ClientServerConnection.run(ClientServerConnection.java:106)
   	at java.base/java.lang.Thread.run(Thread.java:829)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48210][DOC]Modify the description of whether dynamic partition… [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46496:
URL: https://github.com/apache/spark/pull/46496#issuecomment-2463479730

   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org