You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/01/07 21:46:22 UTC

[GitHub] [bookkeeper] pkumar-singh commented on a change in pull request #2975: Changing the routing of ledgers to journal directories

pkumar-singh commented on a change in pull request #2975:
URL: https://github.com/apache/bookkeeper/pull/2975#discussion_r780547147



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java
##########
@@ -1259,7 +1261,17 @@ LedgerDescriptor getLedgerForEntry(ByteBuf entry, final byte[] masterKey)
     }
 
     private Journal getJournal(long ledgerId) {
-        return journals.get(MathUtils.signSafeMod(ledgerId, journals.size()));
+        String dividendString = Double.toString(ledgerId);

Review comment:
       Probably makes more sense to use Long.toString(ledgerId); since ledgerId is long?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org