You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zrlw (via GitHub)" <gi...@apache.org> on 2025/09/15 09:34:44 UTC
[PR] [3.3] Fixed hanging test cases when ZK image was not download successfully [dubbo]
zrlw opened a new pull request, #15693:
URL: https://github.com/apache/dubbo/pull/15693
## What is the purpose of the change?
There are unit tests which need to download Zookeeper image from archive.apache.org before runing test methods, but it might fail even the timeout parameter had been prolonged to 180s,
```
2025-09-11T18:38:26.7288092Z Sep 11, 2025 6:38:26 PM org.junit.platform.launcher.core.CompositeTestExecutionListener lambda$notifyEach$21
2025-09-11T18:38:26.7291148Z 18:38:26.641 |-WARN [AsyncHttpClient-timer-1-1] initializer.DownloadZookeeperInitializer: -| [DUBBO] Failed to download the file, download url: https://archive.apache.org/dist/zookeeper/zookeeper-3.6.0/apache-zookeeper-3.6.0-bin.tar.gz, dubbo version: 3.3.6-SNAPSHOT, current host: 172.31.192.1, error code: 81-3. This may be caused by , go to https://dubbo.apache.org/faq/81/3 to find instructions.
2025-09-11T18:38:26.7295165Z WARNING: TestExecutionListener [org.apache.dubbo.test.check.RegistryCenterStarted] threw exception for method: testPlanExecutionStarted(org.junit.platform.launcher.TestPlan@60e67c06)
2025-09-11T18:38:26.7296970Z java.util.concurrent.TimeoutException: Request timeout to archive.apache.org/65.108.204.189:443 after 180000 ms
```
Junit just log warning message when exception was thrown at DownloadZookeeperInitializer because it is just a TestExecutionListener which does not block the testing process, the follow test methods will hang for ever because there are issues in the codes which will re-connect not-existed ZK server infinitely and keep logging such error info,
```
2025-09-11T18:38:44.4431501Z 18:38:44.338 |-WARN [main-SendThread(127.0.0.1:2181)] org.apache.zookeeper.ClientCnxn:1300 -| Session 0x0 for server 127.0.0.1/127.0.0.1:2181, Closing socket connection. Attempting reconnect except it is a SessionExpiredException.
2025-09-11T18:38:44.4432323Z java.net.ConnectException: Connection refused: getsockopt
2025-09-11T18:38:44.4432692Z at java.base/sun.nio.ch.Net.pollConnect(Native Method) ~[?:?]
2025-09-11T18:38:44.4433061Z at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:682) ~[?:?]
2025-09-11T18:38:44.4433517Z at java.base/sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:975) ~[?:?]
2025-09-11T18:38:44.4434185Z at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:344) ~[zookeeper-3.7.2.jar:3.7.2]
2025-09-11T18:38:44.4434865Z at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1289) [zookeeper-3.7.2.jar:3.7.2]
```
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] Fixed hanging test cases when ZK image was not download successfully [dubbo]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15693:
URL: https://github.com/apache/dubbo/pull/15693#issuecomment-3291389146
## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/15693?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 30.34%. Comparing base ([`50099c1`](https://app.codecov.io/gh/apache/dubbo/commit/50099c107bbf960dbccafbfb61625e26080a72ac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6ad7a65`](https://app.codecov.io/gh/apache/dubbo/commit/6ad7a6511777bf037d15366c7d666975316ec099?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/dubbo/pull/15693?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ng/zookeeper/curator5/Curator5ZookeeperClient.java](https://app.codecov.io/gh/apache/dubbo/pull/15693?src=pr&el=tree&filepath=dubbo-remoting%2Fdubbo-remoting-zookeeper-curator5%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdubbo%2Fremoting%2Fzookeeper%2Fcurator5%2FCurator5ZookeeperClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyLWN1cmF0b3I1L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvY3VyYXRvcjUvQ3VyYXRvcjVab29rZWVwZXJDbGllbnQuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo/pull/15693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (50099c1) and HEAD (6ad7a65). Click for more details.
>
> <details><summary>HEAD has 7 uploads less than BASE</summary>
>
>| Flag | BASE (50099c1) | HEAD (6ad7a65) |
>|------|------|------|
>|samples-tests-java21|1|0|
>|integration-tests-java8|1|0|
>|integration-tests-java21|1|0|
>|unit-tests-java8|1|0|
>|unit-tests-java11|1|0|
>|unit-tests-java17|1|0|
>|unit-tests-java21|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.3 #15693 +/- ##
=============================================
- Coverage 61.02% 30.34% -30.68%
+ Complexity 11700 9368 -2332
=============================================
Files 1923 1923
Lines 87069 87054 -15
Branches 13112 13028 -84
=============================================
- Hits 53131 26420 -26711
- Misses 28492 56548 +28056
+ Partials 5446 4086 -1360
```
| [Flag](https://app.codecov.io/gh/apache/dubbo/pull/15693/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/15693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/15693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [samples-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/15693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [samples-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/15693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `30.34% <0.00%> (+<0.01%)` | :arrow_up: |
| [unit-tests-java11](https://app.codecov.io/gh/apache/dubbo/pull/15693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java17](https://app.codecov.io/gh/apache/dubbo/pull/15693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/15693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/15693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/15693?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] Fixed hanging test cases when failed to download ZK image that due to timeout or other problems [dubbo]
Posted by "zrlw (via GitHub)" <gi...@apache.org>.
zrlw merged PR #15693:
URL: https://github.com/apache/dubbo/pull/15693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org