[GitHub] [doris] morrySnow commented on a diff in pull request #20799: [Improvement](jdbc external table)Support jdbc external table for nereids.

["morrySnow (via GitHub)" <gi...@apache.org>]

morrySnow commented on code in PR #20799:
URL: https://github.com/apache/doris/pull/20799#discussion_r1229437034


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJdbcScan.java:
##########
@@ -31,28 +33,28 @@
 import java.util.Optional;
 
 /**
- * Logical scan for external jdbc catalog.
+ * Logical scan for external jdbc catalog and jdbc table.
  */
 public class LogicalJdbcScan extends LogicalRelation {
 
     /**
      * Constructor for LogicalJdbcScan.
      */
-    public LogicalJdbcScan(ObjectId id, ExternalTable table, List<String> qualifier,
+    public LogicalJdbcScan(ObjectId id, TableIf table, List<String> qualifier,
                            Optional<GroupExpression> groupExpression,
                            Optional<LogicalProperties> logicalProperties) {
         super(id, PlanType.LOGICAL_JDBC_SCAN, table, qualifier,
                 groupExpression, logicalProperties);
     }
 
-    public LogicalJdbcScan(ObjectId id, ExternalTable table, List<String> qualifier) {
+    public LogicalJdbcScan(ObjectId id, TableIf table, List<String> qualifier) {
         this(id, table, qualifier, Optional.empty(), Optional.empty());
     }
 
     @Override
-    public ExternalTable getTable() {
-        Preconditions.checkArgument(table instanceof ExternalTable);
-        return (ExternalTable) table;
+    public TableIf getTable() {
+        Preconditions.checkArgument(table instanceof ExternalTable || table instanceof JdbcTable);

Review Comment:
   please add check error msg



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org