You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Lukas Theussl <lt...@apache.org> on 2006/03/15 18:32:35 UTC
Re: svn commit: r385672 - /maven/maven-1/core/trunk/project.properties
Is there a specific reason for that? In general, I think that test code
should be subject to the same quality criteria as main code.
-Lukas
aheritier@apache.org wrote:
> Author: aheritier
> Date: Mon Mar 13 14:15:20 2006
> New Revision: 385672
>
> URL: http://svn.apache.org/viewcvs?rev=385672&view=rev
> Log:
> Ignore simian reporting in tests classes
>
> Modified:
> maven/maven-1/core/trunk/project.properties
>
> Modified: maven/maven-1/core/trunk/project.properties
> URL: http://svn.apache.org/viewcvs/maven/maven-1/core/trunk/project.properties?rev=385672&r1=385671&r2=385672&view=diff
> ==============================================================================
> --- maven/maven-1/core/trunk/project.properties (original)
> +++ maven/maven-1/core/trunk/project.properties Mon Mar 13 14:15:20 2006
> @@ -117,6 +117,7 @@
> # Simian plugin settings
> #=====
> maven.simian.linecount = 4
> +maven.simian.includetests = false
>
> #=====
> # Site plugin settings
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r385672 - /maven/maven-1/core/trunk/project.properties
Posted by Arnaud HERITIER <ah...@gmail.com>.
It's not really easy to apply the same rules of quality on the main code and
on the tests...
The tests are often very more duplicated (assert.....) especially if you
need to use variables. You can find a lot of : assertTrue(result);
I think that we can focus our improvements on the maincode and when we'll
finish, we'll do it for the tests.
Arnaud
On 3/15/06, Lukas Theussl <lt...@apache.org> wrote:
>
> Is there a specific reason for that? In general, I think that test code
> should be subject to the same quality criteria as main code.
>
> -Lukas
>
>
> aheritier@apache.org wrote:
> > Author: aheritier
> > Date: Mon Mar 13 14:15:20 2006
> > New Revision: 385672
> >
> > URL: http://svn.apache.org/viewcvs?rev=385672&view=rev
> > Log:
> > Ignore simian reporting in tests classes
> >
> > Modified:
> > maven/maven-1/core/trunk/project.properties
> >
> > Modified: maven/maven-1/core/trunk/project.properties
> > URL:
> http://svn.apache.org/viewcvs/maven/maven-1/core/trunk/project.properties?rev=385672&r1=385671&r2=385672&view=diff
> >
> ==============================================================================
> > --- maven/maven-1/core/trunk/project.properties (original)
> > +++ maven/maven-1/core/trunk/project.properties Mon Mar 13 14:15:20 2006
> > @@ -117,6 +117,7 @@
> > # Simian plugin settings
> > #=====
> > maven.simian.linecount = 4
> > +maven.simian.includetests = false
> >
> > #=====
> > # Site plugin settings
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>