You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/09 12:32:53 UTC
[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5012: [1]
Test case modified for int type
ANSHUMAN87 opened a new pull request #5012: [1] Test case modified for int type
URL: https://github.com/apache/incubator-tvm/pull/5012
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5012: [1] Test case
modified for int type
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5012: [1] Test case modified for int type
URL: https://github.com/apache/incubator-tvm/pull/5012#issuecomment-596873783
Please look into the CI error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5012: [1] Test case
modified for int type
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5012: [1] Test case modified for int type
URL: https://github.com/apache/incubator-tvm/pull/5012#issuecomment-596499051
@tqchen , @MarisaKirisame, @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5012: [1] Test case
modified for int type
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5012: [1] Test case modified for int type
URL: https://github.com/apache/incubator-tvm/pull/5012#issuecomment-597719524
The build error should have been fixed by a recent PR, please send a dummy commit to retrigger the CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5012: [1] Test case
modified for int type
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5012: [1] Test case modified for int type
URL: https://github.com/apache/incubator-tvm/pull/5012#issuecomment-598295024
Thanks @ANSHUMAN87 @MarisaKirisame !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #5012: [1] Test case
modified for int type
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5012: [1] Test case modified for int type
URL: https://github.com/apache/incubator-tvm/pull/5012
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5012: [1] Test case
modified for int type
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5012: [1] Test case modified for int type
URL: https://github.com/apache/incubator-tvm/pull/5012#issuecomment-597008709
@tqchen : I am getting build error now in CI, does not look like related to my changes. It is in /tests/scripts/task_rust.sh. May be i will wait for that to get resolved? Please help. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5012: [1] Test case
modified for int type
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5012: [1] Test case modified for int type
URL: https://github.com/apache/incubator-tvm/pull/5012#issuecomment-596916189
> Please look into the CI error
@tqchen : This error does not reproduce in my setup. Looks like some random issue. To isolate i may push some test commits, please ignore them. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5012: [1] Test case
modified for int type
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5012: [1] Test case modified for int type
URL: https://github.com/apache/incubator-tvm/pull/5012#issuecomment-597820620
@tqchen , @MarisaKirisame : I found the root-cause for the CI failure. The reason is the legacy bit-shift operator overflow issue. As the second parameter was higher than 32(bit length of int32), the values produced by tvm operator becomes undefined. However i found numpy behavior is quite stable in this scenario. My personal opinion is to make the behavior inline with numpy.
Currently in test case i have restricted the second parameter for left_shift and right_shift operator to be in range : [1, 31].
Please review and provide your valuable feedback. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services