[jira] [Updated] (TS-629) non-portable char vs integer comparisons

["John Plevyak (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak updated TS-629:
----------------------------

    Attachment: TS-629-jp-1.patch

Updated to the new locations of the code and reviewed.

+1 to commit

> non-portable char vs integer comparisons
> ----------------------------------------
>
>                 Key: TS-629
>                 URL: https://issues.apache.org/jira/browse/TS-629
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Portability
>    Affects Versions: 2.1.5
>         Environment: ARM/Maemo with gcc 4.2.1
>            Reporter: Nick Kew
>            Priority: Minor
>             Fix For: 2.1.8
>
>         Attachments: TS-629-jp-1.patch
>
>
> Several char comparisons fail with "always true" or "always false" on this platform:
> iocore/cluster/ClusterHandlerBase.cc line 148 (is this needed?  Under what circumstances can size_index be negative but not -1)
> iocore/cluster/ClusterProcessor.cc lines 209/210/212 (as above?)
> lib/ts/ParseRules.h line 193 and 253 (platform is fine if we test bitwise-AND 0x80 for negativity)
> proxy/mgmt2/cluster/ClusterCom.cc line 2134 (casting EOF to char fixes it)
> proxy/mgmt2/preparse/IPRange.cc line 112 (as above)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira