You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by siddharth anand <sa...@apache.org> on 2016/05/24 19:50:22 UTC
[VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Hi Folks!
To formalize the RTC vs CTR policy going forward for committing, I'm
putting it to a vote.
"Commits need a +1 vote from a committer who is not the author with the
exception of minor commits"
Anyone can vote, but committer/PPMC votes are binding.
http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
Please respond with -1, 0, +1 or the fractions listed in the link above. If
you are a committer, then please respond "*+/-[0-1] (binding)*",
otherwise "*+/-[0-1]
(non-binding)*"
Voting will be open till Friday 9a PT.
-s
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by siddharth anand <sa...@apache.org>.
Else continue voting :-)
On Tuesday, May 24, 2016, siddharth anand <sa...@apache.org> wrote:
> Actually, that "minor updates" statement should have been dropped. I'm
> surprised no one else noticed it:-)
>
> "Commits need a +1 vote from a committer who is not the author" is what I
> meant. I suspect no one cared or noticed. Hence, if anyone feels this
> changes the vote, respond here and I will cancel and reinitiate the vote.
>
> -s
>
> On Tue, May 24, 2016 at 4:44 PM, Maxime Beauchemin <
> maximebeauchemin@gmail.com
> <javascript:_e(%7B%7D,'cvml','maximebeauchemin@gmail.com');>> wrote:
>
>> +1, though "minor" may need to be defined and I'd say 0 tolerance on
>> Landscape.io and Coveralls.io reports
>>
>> On Tue, May 24, 2016 at 2:31 PM, Hitesh Shah <hitesh@apache.org
>> <javascript:_e(%7B%7D,'cvml','hitesh@apache.org');>> wrote:
>>
>> > +1
>> >
>> > — Hitesh
>> >
>> > > On May 24, 2016, at 12:50 PM, siddharth anand <sanand@apache.org
>> <javascript:_e(%7B%7D,'cvml','sanand@apache.org');>> wrote:
>> > >
>> > > Hi Folks!
>> > > To formalize the RTC vs CTR policy going forward for committing, I'm
>> > > putting it to a vote.
>> > >
>> > > "Commits need a +1 vote from a committer who is not the author with
>> the
>> > > exception of minor commits"
>> > >
>> > >
>> > > Anyone can vote, but committer/PPMC votes are binding.
>> > >
>> > >
>> >
>> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
>> > >
>> > > Please respond with -1, 0, +1 or the fractions listed in the link
>> above.
>> > If
>> > > you are a committer, then please respond "*+/-[0-1] (binding)*",
>> > > otherwise "*+/-[0-1]
>> > > (non-binding)*"
>> > >
>> > >
>> > > Voting will be open till Friday 9a PT.
>> > >
>> > >
>> > > -s
>> >
>> >
>>
>
>
--
Sent from Gmail Mobile
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by siddharth anand <sa...@apache.org>.
Actually, that "minor updates" statement should have been dropped. I'm
surprised no one else noticed it:-)
"Commits need a +1 vote from a committer who is not the author" is what I
meant. I suspect no one cared or noticed. Hence, if anyone feels this
changes the vote, respond here and I will cancel and reinitiate the vote.
-s
On Tue, May 24, 2016 at 4:44 PM, Maxime Beauchemin <
maximebeauchemin@gmail.com> wrote:
> +1, though "minor" may need to be defined and I'd say 0 tolerance on
> Landscape.io and Coveralls.io reports
>
> On Tue, May 24, 2016 at 2:31 PM, Hitesh Shah <hi...@apache.org> wrote:
>
> > +1
> >
> > — Hitesh
> >
> > > On May 24, 2016, at 12:50 PM, siddharth anand <sa...@apache.org>
> wrote:
> > >
> > > Hi Folks!
> > > To formalize the RTC vs CTR policy going forward for committing, I'm
> > > putting it to a vote.
> > >
> > > "Commits need a +1 vote from a committer who is not the author with the
> > > exception of minor commits"
> > >
> > >
> > > Anyone can vote, but committer/PPMC votes are binding.
> > >
> > >
> >
> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
> > >
> > > Please respond with -1, 0, +1 or the fractions listed in the link
> above.
> > If
> > > you are a committer, then please respond "*+/-[0-1] (binding)*",
> > > otherwise "*+/-[0-1]
> > > (non-binding)*"
> > >
> > >
> > > Voting will be open till Friday 9a PT.
> > >
> > >
> > > -s
> >
> >
>
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by Maxime Beauchemin <ma...@gmail.com>.
+1, though "minor" may need to be defined and I'd say 0 tolerance on
Landscape.io and Coveralls.io reports
On Tue, May 24, 2016 at 2:31 PM, Hitesh Shah <hi...@apache.org> wrote:
> +1
>
> — Hitesh
>
> > On May 24, 2016, at 12:50 PM, siddharth anand <sa...@apache.org> wrote:
> >
> > Hi Folks!
> > To formalize the RTC vs CTR policy going forward for committing, I'm
> > putting it to a vote.
> >
> > "Commits need a +1 vote from a committer who is not the author with the
> > exception of minor commits"
> >
> >
> > Anyone can vote, but committer/PPMC votes are binding.
> >
> >
> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
> >
> > Please respond with -1, 0, +1 or the fractions listed in the link above.
> If
> > you are a committer, then please respond "*+/-[0-1] (binding)*",
> > otherwise "*+/-[0-1]
> > (non-binding)*"
> >
> >
> > Voting will be open till Friday 9a PT.
> >
> >
> > -s
>
>
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by Hitesh Shah <hi...@apache.org>.
+1
— Hitesh
> On May 24, 2016, at 12:50 PM, siddharth anand <sa...@apache.org> wrote:
>
> Hi Folks!
> To formalize the RTC vs CTR policy going forward for committing, I'm
> putting it to a vote.
>
> "Commits need a +1 vote from a committer who is not the author with the
> exception of minor commits"
>
>
> Anyone can vote, but committer/PPMC votes are binding.
>
> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
>
> Please respond with -1, 0, +1 or the fractions listed in the link above. If
> you are a committer, then please respond "*+/-[0-1] (binding)*",
> otherwise "*+/-[0-1]
> (non-binding)*"
>
>
> Voting will be open till Friday 9a PT.
>
>
> -s
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by Jakob Homan <jg...@gmail.com>.
+1 binding
On 24 May 2016 at 13:38, Bolke de Bruin <bd...@gmail.com> wrote:
> +1 binding
>
> Sent from my iPhone
>
>> On 24 mei 2016, at 22:23, Dan Davydov <da...@airbnb.com.INVALID> wrote:
>>
>> +1 binding
>>
>>> On Tue, May 24, 2016 at 1:15 PM, Arthur Wiedmer <ar...@apache.org> wrote:
>>>
>>> +1 binding
>>>
>>> On Tue, May 24, 2016 at 1:10 PM, siddharth anand <sa...@apache.org>
>>> wrote:
>>>
>>>> +1 (binding) : FYI, Chris was binding as well.
>>>>
>>>> -s
>>>>
>>>> On Tue, May 24, 2016 at 3:00 PM, Chris Riccomini <cr...@apache.org>
>>>> wrote:
>>>>
>>>>> +1
>>>>>
>>>>> On Tue, May 24, 2016 at 12:50 PM, siddharth anand <sa...@apache.org>
>>>>> wrote:
>>>>>
>>>>>> Hi Folks!
>>>>>> To formalize the RTC vs CTR policy going forward for committing, I'm
>>>>>> putting it to a vote.
>>>>>>
>>>>>> "Commits need a +1 vote from a committer who is not the author with
>>> the
>>>>>> exception of minor commits"
>>>>>>
>>>>>>
>>>>>> Anyone can vote, but committer/PPMC votes are binding.
>>> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
>>>>>>
>>>>>> Please respond with -1, 0, +1 or the fractions listed in the link
>>>> above.
>>>>> If
>>>>>> you are a committer, then please respond "*+/-[0-1] (binding)*",
>>>>>> otherwise "*+/-[0-1]
>>>>>> (non-binding)*"
>>>>>>
>>>>>>
>>>>>> Voting will be open till Friday 9a PT.
>>>>>>
>>>>>>
>>>>>> -s
>>>
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by Bolke de Bruin <bd...@gmail.com>.
+1 binding
Sent from my iPhone
> On 24 mei 2016, at 22:23, Dan Davydov <da...@airbnb.com.INVALID> wrote:
>
> +1 binding
>
>> On Tue, May 24, 2016 at 1:15 PM, Arthur Wiedmer <ar...@apache.org> wrote:
>>
>> +1 binding
>>
>> On Tue, May 24, 2016 at 1:10 PM, siddharth anand <sa...@apache.org>
>> wrote:
>>
>>> +1 (binding) : FYI, Chris was binding as well.
>>>
>>> -s
>>>
>>> On Tue, May 24, 2016 at 3:00 PM, Chris Riccomini <cr...@apache.org>
>>> wrote:
>>>
>>>> +1
>>>>
>>>> On Tue, May 24, 2016 at 12:50 PM, siddharth anand <sa...@apache.org>
>>>> wrote:
>>>>
>>>>> Hi Folks!
>>>>> To formalize the RTC vs CTR policy going forward for committing, I'm
>>>>> putting it to a vote.
>>>>>
>>>>> "Commits need a +1 vote from a committer who is not the author with
>> the
>>>>> exception of minor commits"
>>>>>
>>>>>
>>>>> Anyone can vote, but committer/PPMC votes are binding.
>> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
>>>>>
>>>>> Please respond with -1, 0, +1 or the fractions listed in the link
>>> above.
>>>> If
>>>>> you are a committer, then please respond "*+/-[0-1] (binding)*",
>>>>> otherwise "*+/-[0-1]
>>>>> (non-binding)*"
>>>>>
>>>>>
>>>>> Voting will be open till Friday 9a PT.
>>>>>
>>>>>
>>>>> -s
>>
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by Dan Davydov <da...@airbnb.com.INVALID>.
+1 binding
On Tue, May 24, 2016 at 1:15 PM, Arthur Wiedmer <ar...@apache.org> wrote:
> +1 binding
>
> On Tue, May 24, 2016 at 1:10 PM, siddharth anand <sa...@apache.org>
> wrote:
>
> > +1 (binding) : FYI, Chris was binding as well.
> >
> > -s
> >
> > On Tue, May 24, 2016 at 3:00 PM, Chris Riccomini <cr...@apache.org>
> > wrote:
> >
> > > +1
> > >
> > > On Tue, May 24, 2016 at 12:50 PM, siddharth anand <sa...@apache.org>
> > > wrote:
> > >
> > > > Hi Folks!
> > > > To formalize the RTC vs CTR policy going forward for committing, I'm
> > > > putting it to a vote.
> > > >
> > > > "Commits need a +1 vote from a committer who is not the author with
> the
> > > > exception of minor commits"
> > > >
> > > >
> > > > Anyone can vote, but committer/PPMC votes are binding.
> > > >
> > > >
> > > >
> > >
> >
> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
> > > >
> > > > Please respond with -1, 0, +1 or the fractions listed in the link
> > above.
> > > If
> > > > you are a committer, then please respond "*+/-[0-1] (binding)*",
> > > > otherwise "*+/-[0-1]
> > > > (non-binding)*"
> > > >
> > > >
> > > > Voting will be open till Friday 9a PT.
> > > >
> > > >
> > > > -s
> > > >
> > >
> >
>
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by Arthur Wiedmer <ar...@apache.org>.
+1 binding
On Tue, May 24, 2016 at 1:10 PM, siddharth anand <sa...@apache.org> wrote:
> +1 (binding) : FYI, Chris was binding as well.
>
> -s
>
> On Tue, May 24, 2016 at 3:00 PM, Chris Riccomini <cr...@apache.org>
> wrote:
>
> > +1
> >
> > On Tue, May 24, 2016 at 12:50 PM, siddharth anand <sa...@apache.org>
> > wrote:
> >
> > > Hi Folks!
> > > To formalize the RTC vs CTR policy going forward for committing, I'm
> > > putting it to a vote.
> > >
> > > "Commits need a +1 vote from a committer who is not the author with the
> > > exception of minor commits"
> > >
> > >
> > > Anyone can vote, but committer/PPMC votes are binding.
> > >
> > >
> > >
> >
> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
> > >
> > > Please respond with -1, 0, +1 or the fractions listed in the link
> above.
> > If
> > > you are a committer, then please respond "*+/-[0-1] (binding)*",
> > > otherwise "*+/-[0-1]
> > > (non-binding)*"
> > >
> > >
> > > Voting will be open till Friday 9a PT.
> > >
> > >
> > > -s
> > >
> >
>
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by siddharth anand <sa...@apache.org>.
+1 (binding) : FYI, Chris was binding as well.
-s
On Tue, May 24, 2016 at 3:00 PM, Chris Riccomini <cr...@apache.org>
wrote:
> +1
>
> On Tue, May 24, 2016 at 12:50 PM, siddharth anand <sa...@apache.org>
> wrote:
>
> > Hi Folks!
> > To formalize the RTC vs CTR policy going forward for committing, I'm
> > putting it to a vote.
> >
> > "Commits need a +1 vote from a committer who is not the author with the
> > exception of minor commits"
> >
> >
> > Anyone can vote, but committer/PPMC votes are binding.
> >
> >
> >
> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
> >
> > Please respond with -1, 0, +1 or the fractions listed in the link above.
> If
> > you are a committer, then please respond "*+/-[0-1] (binding)*",
> > otherwise "*+/-[0-1]
> > (non-binding)*"
> >
> >
> > Voting will be open till Friday 9a PT.
> >
> >
> > -s
> >
>
Re: [VOTE] Review-then-commit (RTC) vs Commit-then-review (CTR)
Posted by Chris Riccomini <cr...@apache.org>.
+1
On Tue, May 24, 2016 at 12:50 PM, siddharth anand <sa...@apache.org> wrote:
> Hi Folks!
> To formalize the RTC vs CTR policy going forward for committing, I'm
> putting it to a vote.
>
> "Commits need a +1 vote from a committer who is not the author with the
> exception of minor commits"
>
>
> Anyone can vote, but committer/PPMC votes are binding.
>
>
> http://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
>
> Please respond with -1, 0, +1 or the fractions listed in the link above. If
> you are a committer, then please respond "*+/-[0-1] (binding)*",
> otherwise "*+/-[0-1]
> (non-binding)*"
>
>
> Voting will be open till Friday 9a PT.
>
>
> -s
>