You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dolphinscheduler.apache.org by Jave-Chen <ba...@gmail.com> on 2020/07/13 15:03:11 UTC

Changing SonarCloud Code Analysis on github to be unrequired

Hi, folks

Currently we use sonar in CI to  analyze the quality of backend java code.
So sonar will not
analyze  the front-end code. But some pr is to fix the front-end issues, at
the same
time github has set sonar checks as required. So these PRs  will never
pass, like [1].

So I suggest changing SonarCloud Code Analysis on github to be unrequired.

I will wait one day. If no one raises new questions, we will follow this
plan.

[1] https://github.com/apache/incubator-dolphinscheduler/pull/3200

Re: Changing SonarCloud Code Analysis on github to be unrequired

Posted by lidong dai <da...@gmail.com>.
 I think sonarcloud parse process is so slow, I suggest unset required



Best Regards
---------------
DolphinScheduler(Incubator) PPMC
Lidong Dai 代立冬
dailidong66@gmail.com
---------------


lidong dai <da...@gmail.com> 于2020年7月15日周三 上午11:13写道：

> any updates?
>
>
>
> Best Regards
> ---------------
> DolphinScheduler(Incubator) PPMC
> Lidong Dai 代立冬
> dailidong66@gmail.com
> ---------------
>
>
> Yichao Yang <10...@qq.com> 于2020年7月14日周二 下午12:51写道：
>
>> Hi,
>>
>>
>> Agree with @gabrywu.
>> maybe we can try to find the settings to let sonar analyze the java code
>> only.
>>
>>
>> Best,
>> Yichao Yang
>>
>>
>>
>>
>> ------------------&nbsp;原始邮件&nbsp;------------------
>> 发件人:
>>                                                   "dev"
>>                                                                 <
>> gabrywu@apache.org&gt;;
>> 发送时间:&nbsp;2020年7月14日(星期二) 中午12:48
>> 收件人:&nbsp;"dev@dolphinscheduler.apache.org"<
>> dev@dolphinscheduler.apache.org&gt;;
>>
>> 主题:&nbsp;Re: Changing SonarCloud Code Analysis on github to be unrequired
>>
>>
>>
>> Is there an alternative CI ? Is there a setting to let sonar analyze the
>> java code only?
>>
>> On 2020/7/14, 12:00, "lidong dai" <dailidong66@gmail.com&gt; wrote:
>>
>> &nbsp;&nbsp;&nbsp; +1
>> &nbsp;&nbsp;&nbsp; can't agree with more
>>
>>
>>
>> &nbsp;&nbsp;&nbsp; Best Regards
>> &nbsp;&nbsp;&nbsp; ---------------
>> &nbsp;&nbsp;&nbsp; DolphinScheduler(Incubator) PPMC
>> &nbsp;&nbsp;&nbsp; Lidong Dai 代立冬
>> &nbsp;&nbsp;&nbsp; dailidong66@gmail.com
>> &nbsp;&nbsp;&nbsp; ---------------
>>
>>
>> &nbsp;&nbsp;&nbsp; Jave-Chen <baicai.chen@gmail.com&gt; 于2020年7月13日周一
>> 下午11:03写道：
>>
>> &nbsp;&nbsp;&nbsp; &gt; Hi, folks
>> &nbsp;&nbsp;&nbsp; &gt;
>> &nbsp;&nbsp;&nbsp; &gt; Currently we use sonar in CI to&nbsp; analyze the
>> quality of backend java code.
>> &nbsp;&nbsp;&nbsp; &gt; So sonar will not
>> &nbsp;&nbsp;&nbsp; &gt; analyze&nbsp; the front-end code. But some pr is
>> to fix the front-end issues, at
>> &nbsp;&nbsp;&nbsp; &gt; the same
>> &nbsp;&nbsp;&nbsp; &gt; time github has set sonar checks as required. So
>> these PRs&nbsp; will never
>> &nbsp;&nbsp;&nbsp; &gt; pass, like [1].
>> &nbsp;&nbsp;&nbsp; &gt;
>> &nbsp;&nbsp;&nbsp; &gt; So I suggest changing SonarCloud Code Analysis on
>> github to be unrequired.
>> &nbsp;&nbsp;&nbsp; &gt;
>> &nbsp;&nbsp;&nbsp; &gt; I will wait one day. If no one raises new
>> questions, we will follow this
>> &nbsp;&nbsp;&nbsp; &gt; plan.
>> &nbsp;&nbsp;&nbsp; &gt;
>> &nbsp;&nbsp;&nbsp; &gt; [1]
>> https://github.com/apache/incubator-dolphinscheduler/pull/3200
>> &nbsp;&nbsp;&nbsp
>> <https://github.com/apache/incubator-dolphinscheduler/pull/3200&nbsp;&nbsp;&nbsp>;
>> &gt;
>
>

Re: Changing SonarCloud Code Analysis on github to be unrequired

Posted by lidong dai <da...@gmail.com>.
any updates?



Best Regards
---------------
DolphinScheduler(Incubator) PPMC
Lidong Dai 代立冬
dailidong66@gmail.com
---------------


Yichao Yang <10...@qq.com> 于2020年7月14日周二 下午12:51写道：

> Hi,
>
>
> Agree with @gabrywu.
> maybe we can try to find the settings to let sonar analyze the java code
> only.
>
>
> Best,
> Yichao Yang
>
>
>
>
> ------------------&nbsp;原始邮件&nbsp;------------------
> 发件人:
>                                                   "dev"
>                                                                 <
> gabrywu@apache.org&gt;;
> 发送时间:&nbsp;2020年7月14日(星期二) 中午12:48
> 收件人:&nbsp;"dev@dolphinscheduler.apache.org"<
> dev@dolphinscheduler.apache.org&gt;;
>
> 主题:&nbsp;Re: Changing SonarCloud Code Analysis on github to be unrequired
>
>
>
> Is there an alternative CI ? Is there a setting to let sonar analyze the
> java code only?
>
> On 2020/7/14, 12:00, "lidong dai" <dailidong66@gmail.com&gt; wrote:
>
> &nbsp;&nbsp;&nbsp; +1
> &nbsp;&nbsp;&nbsp; can't agree with more
>
>
>
> &nbsp;&nbsp;&nbsp; Best Regards
> &nbsp;&nbsp;&nbsp; ---------------
> &nbsp;&nbsp;&nbsp; DolphinScheduler(Incubator) PPMC
> &nbsp;&nbsp;&nbsp; Lidong Dai 代立冬
> &nbsp;&nbsp;&nbsp; dailidong66@gmail.com
> &nbsp;&nbsp;&nbsp; ---------------
>
>
> &nbsp;&nbsp;&nbsp; Jave-Chen <baicai.chen@gmail.com&gt; 于2020年7月13日周一
> 下午11:03写道：
>
> &nbsp;&nbsp;&nbsp; &gt; Hi, folks
> &nbsp;&nbsp;&nbsp; &gt;
> &nbsp;&nbsp;&nbsp; &gt; Currently we use sonar in CI to&nbsp; analyze the
> quality of backend java code.
> &nbsp;&nbsp;&nbsp; &gt; So sonar will not
> &nbsp;&nbsp;&nbsp; &gt; analyze&nbsp; the front-end code. But some pr is
> to fix the front-end issues, at
> &nbsp;&nbsp;&nbsp; &gt; the same
> &nbsp;&nbsp;&nbsp; &gt; time github has set sonar checks as required. So
> these PRs&nbsp; will never
> &nbsp;&nbsp;&nbsp; &gt; pass, like [1].
> &nbsp;&nbsp;&nbsp; &gt;
> &nbsp;&nbsp;&nbsp; &gt; So I suggest changing SonarCloud Code Analysis on
> github to be unrequired.
> &nbsp;&nbsp;&nbsp; &gt;
> &nbsp;&nbsp;&nbsp; &gt; I will wait one day. If no one raises new
> questions, we will follow this
> &nbsp;&nbsp;&nbsp; &gt; plan.
> &nbsp;&nbsp;&nbsp; &gt;
> &nbsp;&nbsp;&nbsp; &gt; [1]
> https://github.com/apache/incubator-dolphinscheduler/pull/3200
> &nbsp;&nbsp;&nbsp
> <https://github.com/apache/incubator-dolphinscheduler/pull/3200&nbsp;&nbsp;&nbsp>;
> &gt;

回复： Changing SonarCloud Code Analysis on github to be unrequired

Posted by Yichao Yang <10...@qq.com>.
Hi,


Agree with @gabrywu.
maybe we can try to find the settings to let sonar analyze the java code only.


Best,
Yichao Yang




------------------&nbsp;原始邮件&nbsp;------------------
发件人:                                                                                                                        "dev"                                                                                    <gabrywu@apache.org&gt;;
发送时间:&nbsp;2020年7月14日(星期二) 中午12:48
收件人:&nbsp;"dev@dolphinscheduler.apache.org"<dev@dolphinscheduler.apache.org&gt;;

主题:&nbsp;Re: Changing SonarCloud Code Analysis on github to be unrequired



Is there an alternative CI ? Is there a setting to let sonar analyze the java code only?

On 2020/7/14, 12:00, "lidong dai" <dailidong66@gmail.com&gt; wrote:

&nbsp;&nbsp;&nbsp; +1
&nbsp;&nbsp;&nbsp; can't agree with more



&nbsp;&nbsp;&nbsp; Best Regards
&nbsp;&nbsp;&nbsp; ---------------
&nbsp;&nbsp;&nbsp; DolphinScheduler(Incubator) PPMC
&nbsp;&nbsp;&nbsp; Lidong Dai 代立冬
&nbsp;&nbsp;&nbsp; dailidong66@gmail.com
&nbsp;&nbsp;&nbsp; ---------------


&nbsp;&nbsp;&nbsp; Jave-Chen <baicai.chen@gmail.com&gt; 于2020年7月13日周一 下午11:03写道：

&nbsp;&nbsp;&nbsp; &gt; Hi, folks
&nbsp;&nbsp;&nbsp; &gt;
&nbsp;&nbsp;&nbsp; &gt; Currently we use sonar in CI to&nbsp; analyze the quality of backend java code.
&nbsp;&nbsp;&nbsp; &gt; So sonar will not
&nbsp;&nbsp;&nbsp; &gt; analyze&nbsp; the front-end code. But some pr is to fix the front-end issues, at
&nbsp;&nbsp;&nbsp; &gt; the same
&nbsp;&nbsp;&nbsp; &gt; time github has set sonar checks as required. So these PRs&nbsp; will never
&nbsp;&nbsp;&nbsp; &gt; pass, like [1].
&nbsp;&nbsp;&nbsp; &gt;
&nbsp;&nbsp;&nbsp; &gt; So I suggest changing SonarCloud Code Analysis on github to be unrequired.
&nbsp;&nbsp;&nbsp; &gt;
&nbsp;&nbsp;&nbsp; &gt; I will wait one day. If no one raises new questions, we will follow this
&nbsp;&nbsp;&nbsp; &gt; plan.
&nbsp;&nbsp;&nbsp; &gt;
&nbsp;&nbsp;&nbsp; &gt; [1] https://github.com/apache/incubator-dolphinscheduler/pull/3200
&nbsp;&nbsp;&nbsp; &gt;

Re: Changing SonarCloud Code Analysis on github to be unrequired

Posted by wu shaoj <ga...@apache.org>.
Is there an alternative CI ? Is there a setting to let sonar analyze the java code only?

On 2020/7/14, 12:00, "lidong dai" <da...@gmail.com> wrote:

    +1
    can't agree with more



    Best Regards
    ---------------
    DolphinScheduler(Incubator) PPMC
    Lidong Dai 代立冬
    dailidong66@gmail.com
    ---------------


    Jave-Chen <ba...@gmail.com> 于2020年7月13日周一 下午11:03写道：

    > Hi, folks
    >
    > Currently we use sonar in CI to  analyze the quality of backend java code.
    > So sonar will not
    > analyze  the front-end code. But some pr is to fix the front-end issues, at
    > the same
    > time github has set sonar checks as required. So these PRs  will never
    > pass, like [1].
    >
    > So I suggest changing SonarCloud Code Analysis on github to be unrequired.
    >
    > I will wait one day. If no one raises new questions, we will follow this
    > plan.
    >
    > [1] https://github.com/apache/incubator-dolphinscheduler/pull/3200
    >

Re: Changing SonarCloud Code Analysis on github to be unrequired

Posted by lidong dai <da...@gmail.com>.
+1
can't agree with more



Best Regards
---------------
DolphinScheduler(Incubator) PPMC
Lidong Dai 代立冬
dailidong66@gmail.com
---------------


Jave-Chen <ba...@gmail.com> 于2020年7月13日周一 下午11:03写道：

> Hi, folks
>
> Currently we use sonar in CI to  analyze the quality of backend java code.
> So sonar will not
> analyze  the front-end code. But some pr is to fix the front-end issues, at
> the same
> time github has set sonar checks as required. So these PRs  will never
> pass, like [1].
>
> So I suggest changing SonarCloud Code Analysis on github to be unrequired.
>
> I will wait one day. If no one raises new questions, we will follow this
> plan.
>
> [1] https://github.com/apache/incubator-dolphinscheduler/pull/3200
>