You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/08 15:42:20 UTC
[GitHub] [fineract-cn-mobile] EGOR-IND opened a new pull request #120: fix the activity_debt_income_report.xml Toolbar scrolling behavior
EGOR-IND opened a new pull request #120:
URL: https://github.com/apache/fineract-cn-mobile/pull/120
Fixes FINCN-246
https://user-images.githubusercontent.com/56648862/110343521-93c88e00-8052-11eb-9e8d-9474ce75ec3f.mp4
Stopped the toolbar from scrolling upward.
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
- [x] If you have multiple commits please combine them into one commit by squashing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #120: fix the activity_debt_income_report.xml Toolbar scrolling behavior
Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #120:
URL: https://github.com/apache/fineract-cn-mobile/pull/120#issuecomment-792869556
@varsvat this was a bad idea, I'm regretting making this PR, I'm closing this PR. The scroll behavior looked much interactive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #120: fix the activity_debt_income_report.xml Toolbar scrolling behavior
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #120:
URL: https://github.com/apache/fineract-cn-mobile/pull/120#issuecomment-792852790
We can also add animation in which the back button would come in the tab bar on sliding up ? Opinions ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND closed pull request #120: fix the activity_debt_income_report.xml Toolbar scrolling behavior
Posted by GitBox <gi...@apache.org>.
EGOR-IND closed pull request #120:
URL: https://github.com/apache/fineract-cn-mobile/pull/120
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #120: fix the activity_debt_income_report.xml Toolbar scrolling behavior
Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #120:
URL: https://github.com/apache/fineract-cn-mobile/pull/120#issuecomment-792864702
> We can also add animation in which the back button would come in the tab bar on sliding up ? Opinions ?
Yeah, that's a good idea i was actually thinking of adding float button while keeping the scrolling behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat edited a comment on pull request #120: fix the activity_debt_income_report.xml Toolbar scrolling behavior
Posted by GitBox <gi...@apache.org>.
varsvat edited a comment on pull request #120:
URL: https://github.com/apache/fineract-cn-mobile/pull/120#issuecomment-792884503
It happens . Let's make an habit to discuss about any change or improvement on the jira issue tracker or IRC channel initially and if it seems like a good idea , one can go ahead with it. This would improve the work flow I guess
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #120: fix the activity_debt_income_report.xml Toolbar scrolling behavior
Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #120:
URL: https://github.com/apache/fineract-cn-mobile/pull/120#issuecomment-792918095
> It happens . Let's make an habit to discuss about any change or improvement on the jira issue tracker or IRC channel initially and if it seems like a good idea , one can go ahead with it. This would improve the work flow I guess
Yeah sure man actually I saw that it's a very small change so I rushed it, from now on we'll discuss everything about changes on JIRA and IRC, just like professional developers XD.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #120: fix the activity_debt_income_report.xml Toolbar scrolling behavior
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #120:
URL: https://github.com/apache/fineract-cn-mobile/pull/120#issuecomment-792884503
It happens. Let's make an habit to discuss about any change or improvement on the jira issue tracker or IRC channel. This would improve the work flow ig
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #120: fix the activity_debt_income_report.xml Toolbar scrolling behavior
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #120:
URL: https://github.com/apache/fineract-cn-mobile/pull/120#issuecomment-792851049
I would suggest not to remove the scroll behaviour of the toolbar , it gives a better UI/UX experience and anyways , the user will slide to the top if he has to press back button and which is quite intuitive acc. to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org