You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/07/10 14:46:50 UTC
[GitHub] michal-narajowski commented on a change in pull request #191: Cmake
fixes
michal-narajowski commented on a change in pull request #191: Cmake fixes
URL: https://github.com/apache/mynewt-newt/pull/191#discussion_r201372188
##########
File path: newt/builder/cmake.go
##########
@@ -263,7 +244,7 @@ func CmakeCompilerInfoWrite(w io.Writer, archiveFile string, bpkg *BuildPackage,
includes = append(includes, c.GetLocalCompilerInfo().Includes...)
includes = append(includes, otherIncludes...)
- includes = removeDuplicates(includes)
+ includes = util.SortFields(includes...)
Review comment:
This function also removes duplicates. It is used by newt when compiling, so it should be ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services