You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2021/03/15 10:00:49 UTC

[GitHub] [bahir-flink] eskabetxe commented on a change in pull request #121: [BAHIR-247] Provide connection validation/idle testing for Flink-Redis Connector

eskabetxe commented on a change in pull request #121:
URL: https://github.com/apache/bahir-flink/pull/121#discussion_r594191993



##########
File path: flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/FlinkJedisConfigBase.java
##########
@@ -91,6 +99,18 @@ public int getMinIdle() {
         return minIdle;
     }
 
+    public boolean isTestOnBorrow() {

Review comment:
       we have the getTestOnBorrow could we use that and eliminate this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org