You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/12/08 20:18:06 UTC

[GitHub] [hbase] saintstack opened a new pull request #2755: HBASE-25376 [create-release] Fix double .asc

saintstack opened a new pull request #2755:
URL: https://github.com/apache/hbase/pull/2755


   Don't install when we call deploy -- makes for doubling of .asc.
   Added more to the README while in here and added logging
   timestamp so we can tell where we are spending time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] saintstack commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
saintstack commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-741904830


   @apurtell  One liner now. No need of install target when you call deploy. See JIRA for 'proof' change works. #2758 has the logging+README change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] apurtell commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-741014107


   Maybe do the one liner here and the misc cleanups on another? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-740974223


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  3s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  7s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   2m 31s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2755/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2755 |
   | Optional Tests |  |
   | uname | Linux 3b246bbe0bf4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 56dd3eba81 |
   | Max. process+thread count | 54 (vs. ulimit of 30000) |
   | modules | C:  U:  |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2755/1/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] saintstack merged pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
saintstack merged pull request #2755:
URL: https://github.com/apache/hbase/pull/2755


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-741904298






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] saintstack commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
saintstack commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-741892699


   bq. 99% of the changes are out of scope for the fix?
   
   np


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-741368396






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] apurtell commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-741970436


   Ah and that's how my manual invocation messed up too, I did "mvn clean install deploy" (sigh)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-740974679






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-741904191


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  6s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  7s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  7s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   2m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2755/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2755 |
   | Optional Tests |  |
   | uname | Linux ab063fc240ed 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / c853c99b20 |
   | Max. process+thread count | 45 (vs. ulimit of 30000) |
   | modules | C:  U:  |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2755/3/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache9 commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #2755:
URL: https://github.com/apache/hbase/pull/2755#issuecomment-741329391


   > 99% of the changes are out of scope for the fix?
   
   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org