You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Hyukjin Kwon (Jira)" <ji...@apache.org> on 2023/01/12 09:25:00 UTC

[jira] [Resolved] (SPARK-41989) PYARROW_IGNORE_TIMEZONE warning can break application logging setup

     [ https://issues.apache.org/jira/browse/SPARK-41989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hyukjin Kwon resolved SPARK-41989.
----------------------------------
    Fix Version/s: 3.4.0
       Resolution: Fixed

Issue resolved by pull request 39516
[https://github.com/apache/spark/pull/39516]

> PYARROW_IGNORE_TIMEZONE warning can break application logging setup
> -------------------------------------------------------------------
>
>                 Key: SPARK-41989
>                 URL: https://issues.apache.org/jira/browse/SPARK-41989
>             Project: Spark
>          Issue Type: Bug
>          Components: PySpark
>    Affects Versions: 3.2.3
>         Environment: python 3.9 env with pyspark installed
>            Reporter: Stefaan Lippens
>            Assignee: Stefaan Lippens
>            Priority: Major
>             Fix For: 3.4.0
>
>
> in {code}python/pyspark/pandas/__init__.py{code}  there is currently a warning when {{PYARROW_IGNORE_TIMEZONE}} env var is not set (https://github.com/apache/spark/blob/187c4a9c66758e973633c5c309b551b1d9094e6e/python/pyspark/pandas/__init__.py#L44-L59):
> {code:python}
>     import logging
>     logging.warning(
>         "'PYARROW_IGNORE_TIMEZONE' environment variable was not set. It is required to "...
> {code}
> The {{logging.warning()}} call  will silently do a {{logging.basicConfig()}} call (at least in python 3.9, which I tried).
> (FYI: Something like {{logging.getLogger(...).warning()}} would not do this silent call)
> This has the following very hard to figure out side-effect:
> importing `pyspark.pandas` (directly or indirectly somewhere)  might break your logging setup (if PYARROW_IGNORE_TIMEZONE is not set).
> Very basic  example (assuming PYARROW_IGNORE_TIMEZONE is not set):
> {code:python}
> import logging
> import pyspark.pandas
> logging.basicConfig(level=logging.DEBUG)
> logger = logging.getLogger("test")
> logger.warning("I warn you")
> logger.debug("I debug you")
> {code}
> Will only produce the warning, not the debug line.
> By removing the {{import pyspark.pandas}}, the debug line is produced



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org