You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Prab-27 (via GitHub)" <gi...@apache.org> on 2026/01/06 16:49:07 UTC
[PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Prab-27 opened a new pull request, #60177:
URL: https://github.com/apache/airflow/pull/60177
closes : #59908
Update vertica provider hook
Update Pyproject.toml
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #60177:
URL: https://github.com/apache/airflow/pull/60177#discussion_r2674197436
##########
providers/vertica/pyproject.toml:
##########
Review Comment:
> If needed, I’ll create PRs to update the merged changes — please let me know
good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #60177:
URL: https://github.com/apache/airflow/pull/60177#discussion_r2678814584
##########
providers/vertica/pyproject.toml:
##########
Review Comment:
> > If needed, I’ll create PRs to update the merged changes — please let me know
>
> good idea.
started working on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #60177:
URL: https://github.com/apache/airflow/pull/60177#discussion_r2665647601
##########
providers/vertica/src/airflow/providers/vertica/hooks/vertica.py:
##########
@@ -137,6 +142,11 @@ def get_conn(self) -> connect:
@property
def sqlalchemy_url(self) -> URL:
Review Comment:
Okay I'll do this but
why it didn't fail in local mypy check ? (when running prek ? )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #60177:
URL: https://github.com/apache/airflow/pull/60177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #60177:
URL: https://github.com/apache/airflow/pull/60177#discussion_r2665624752
##########
providers/vertica/src/airflow/providers/vertica/hooks/vertica.py:
##########
@@ -137,6 +142,11 @@ def get_conn(self) -> connect:
@property
def sqlalchemy_url(self) -> URL:
Review Comment:
I think it will fail `mypy` tests now that we moved to sqlalchemy 2. We need to add typechecking exclusion likely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #60177:
URL: https://github.com/apache/airflow/pull/60177#discussion_r2665642841
##########
providers/vertica/pyproject.toml:
##########
Review Comment:
Yeah , I'll do !!
Yes from my observation, many PRs related to this don’t have` SQLAlchemy` in the dev group.
If needed, I’ll create PRs to update the merged changes — please let me know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #60177:
URL: https://github.com/apache/airflow/pull/60177#discussion_r2665621123
##########
providers/vertica/pyproject.toml:
##########
Review Comment:
Similarly to impala - let's add `apache-airflow-providers-vertica[sqlalchemy]` here (and I will review if we have not missed it in other places)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #60177:
URL: https://github.com/apache/airflow/pull/60177#discussion_r2665647601
##########
providers/vertica/src/airflow/providers/vertica/hooks/vertica.py:
##########
@@ -137,6 +142,11 @@ def get_conn(self) -> connect:
@property
def sqlalchemy_url(self) -> URL:
Review Comment:
Okay I'll do this
but it why it didn't fail in local mypy check ? (when running prek ? )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make SQLAlchemy optional dependency for vertica Provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #60177:
URL: https://github.com/apache/airflow/pull/60177#discussion_r2665897735
##########
providers/vertica/src/airflow/providers/vertica/hooks/vertica.py:
##########
@@ -137,6 +142,11 @@ def get_conn(self) -> connect:
@property
def sqlalchemy_url(self) -> URL:
Review Comment:
local prek does not run mypy - unless you run it with `--hook-stage manual`. It takes long to run so we do not want it to happen locally for all changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org