You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/06/01 15:26:11 UTC
[kudu-CR] WIP: Kudu Backup/Restore Spark Jobs
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10375 )
Change subject: WIP: Kudu Backup/Restore Spark Jobs
......................................................................
Patch Set 10:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/protobuf/backup.proto
File java/kudu-backup/src/main/protobuf/backup.proto:
http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/protobuf/backup.proto@36
PS10, Line 36: message ColumnMetadataPB {
> This PB doesn't need to be synchronized with the internal ColumnSchemaPB; i
+1 to what adar said. I am writing some generic tests that will iterate over "all" options that would hopefully exposing a missing feature, unsupported type, etc.
http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala:
http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala@37
PS10, Line 37: opt[Boolean]("createTables")
> nit: maybe this should be required with a fallback (default value)?
Is that different than optional with a default value? Currently this defaults to false because the KuduRestoreOptions class defaults it to `defaultCreateTables`.
--
To view, visit http://gerrit.cloudera.org:8080/10375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02183a2f833ffa0225eb7b0a35fc7531109e6f7
Gerrit-Change-Number: 10375
Gerrit-PatchSet: 10
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Jun 2018 15:26:11 +0000
Gerrit-HasComments: Yes