[GitHub] [iceberg] kbendick commented on a diff in pull request #5427: API/Core: Scan reporting result wrappers and parsers

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5427:
URL: https://github.com/apache/iceberg/pull/5427#discussion_r937010131


##########
api/src/main/java/org/apache/iceberg/io/CloseableIterable.java:
##########
@@ -73,6 +74,36 @@ public CloseableIterator<E> iterator() {
     };
   }
 
+  /**
+   * Will run the given runnable when {@link CloseableIterable#close()} has been called.
+   *
+   * @param iterable The underlying {@link CloseableIterable} to iterate over
+   * @param onCompletionRunnable The runnable to run after the underlying iterable was closed
+   * @param <E> The type of the underlying iterable
+   * @return A new {@link CloseableIterable} where the runnable will be executed as the final step
+   *     after {@link CloseableIterable#close()} has been called
+   */
+  static <E> CloseableIterable<E> whenComplete(
+      CloseableIterable<E> iterable, Runnable onCompletionRunnable) {
+    Preconditions.checkNotNull(
+        onCompletionRunnable, "Cannot execute a null Runnable after completion");

Review Comment:
   Nit: Maybe `Invalid runnable: null`? I usually figure that the stack trace will have the remaining information that'd needed. In that it will have `whenComplete` in it, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org