You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/09/18 09:40:17 UTC

Review Request 14198: [OOZIE-1524] Change Workflow SELECT query to fetch only necessary columns and consolidate JPA Executors

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14198/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1524
    https://issues.apache.org/jira/browse/OOZIE-1524


Repository: oozie


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1524
changed workflow job/action SELECT query of frequently-used commands. 


Diffs
-----

  trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1524157 
  trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1524157 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1524157 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1524157 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1524157 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1524157 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1524157 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1524157 

Diff: https://reviews.apache.org/r/14198/diff/


Testing
-------

ran all test cases


Thanks,

Ryota Egashira


Re: Review Request 14198: [OOZIE-1524] Change Workflow SELECT query to fetch only necessary columns and consolidate JPA Executors

Posted by Ryota Egashira <eg...@yahoo-inc.com>.

> On Sept. 18, 2013, 5:07 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java, lines 344-345
> > <https://reviews.apache.org/r/14198/diff/1/?file=353144#file353144line344>
> >
> >     Does this have any impact?

no, this was there  for oldAction = jpaService.execute(new WorkflowActionGetJPAExecutor(newAction.getId())); but we can set new pending value to oldaction without doing this extra DB call, thus i removed it.  thus exception handling not needed any more.


- Ryota


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14198/#review26216
-----------------------------------------------------------


On Sept. 18, 2013, 5:42 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14198/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 5:42 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1524
>     https://issues.apache.org/jira/browse/OOZIE-1524
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1524
> changed workflow job/action SELECT query of frequently-used commands. 
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1524222 
>   trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1524482 
> 
> Diff: https://reviews.apache.org/r/14198/diff/
> 
> 
> Testing
> -------
> 
> ran all test cases
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>


Re: Review Request 14198: [OOZIE-1524] Change Workflow SELECT query to fetch only necessary columns and consolidate JPA Executors

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14198/#review26216
-----------------------------------------------------------


Just few minor comments. Looks good.


trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java
<https://reviews.apache.org/r/14198/#comment51234>

    Ensure in future that you don't end up formatting existing code when that is not modified as part of the patch.



trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java
<https://reviews.apache.org/r/14198/#comment51233>

    Does this have any impact?



trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java
<https://reviews.apache.org/r/14198/#comment51235>

    Each in its own line



trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java
<https://reviews.apache.org/r/14198/#comment51236>

    You can group all the cases together as they have the same action to be performed instead of repeating it and breaking everytime.



trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java
<https://reviews.apache.org/r/14198/#comment51241>

    To be removed


- Rohini Palaniswamy


On Sept. 18, 2013, 4:32 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14198/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 4:32 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1524
>     https://issues.apache.org/jira/browse/OOZIE-1524
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1524
> changed workflow job/action SELECT query of frequently-used commands. 
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1524222 
>   trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1524482 
> 
> Diff: https://reviews.apache.org/r/14198/diff/
> 
> 
> Testing
> -------
> 
> ran all test cases
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>


Re: Review Request 14198: [OOZIE-1524] Change Workflow SELECT query to fetch only necessary columns and consolidate JPA Executors

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14198/#review26230
-----------------------------------------------------------

Ship it!



trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java
<https://reviews.apache.org/r/14198/#comment51252>

    white space


- Rohini Palaniswamy


On Sept. 18, 2013, 5:42 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14198/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 5:42 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1524
>     https://issues.apache.org/jira/browse/OOZIE-1524
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1524
> changed workflow job/action SELECT query of frequently-used commands. 
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1524222 
>   trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1524482 
>   trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1524482 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1524482 
> 
> Diff: https://reviews.apache.org/r/14198/diff/
> 
> 
> Testing
> -------
> 
> ran all test cases
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>


Re: Review Request 14198: [OOZIE-1524] Change Workflow SELECT query to fetch only necessary columns and consolidate JPA Executors

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14198/
-----------------------------------------------------------

(Updated Sept. 18, 2013, 6:34 p.m.)


Review request for oozie.


Changes
-------

final version


Bugs: OOZIE-1524
    https://issues.apache.org/jira/browse/OOZIE-1524


Repository: oozie


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1524
changed workflow job/action SELECT query of frequently-used commands. 


Diffs (updated)
-----

  trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1524222 
  trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1524482 

Diff: https://reviews.apache.org/r/14198/diff/


Testing
-------

ran all test cases


Thanks,

Ryota Egashira


Re: Review Request 14198: [OOZIE-1524] Change Workflow SELECT query to fetch only necessary columns and consolidate JPA Executors

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14198/
-----------------------------------------------------------

(Updated Sept. 18, 2013, 5:42 p.m.)


Review request for oozie.


Changes
-------

addressed review comments


Bugs: OOZIE-1524
    https://issues.apache.org/jira/browse/OOZIE-1524


Repository: oozie


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1524
changed workflow job/action SELECT query of frequently-used commands. 


Diffs (updated)
-----

  trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1524222 
  trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1524482 

Diff: https://reviews.apache.org/r/14198/diff/


Testing
-------

ran all test cases


Thanks,

Ryota Egashira


Re: Review Request 14198: [OOZIE-1524] Change Workflow SELECT query to fetch only necessary columns and consolidate JPA Executors

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14198/
-----------------------------------------------------------

(Updated Sept. 18, 2013, 4:32 p.m.)


Review request for oozie.


Changes
-------

fixed minor thing and rebased patch


Bugs: OOZIE-1524
    https://issues.apache.org/jira/browse/OOZIE-1524


Repository: oozie


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1524
changed workflow job/action SELECT query of frequently-used commands. 


Diffs (updated)
-----

  trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1524222 
  trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1524482 
  trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1524482 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1524482 

Diff: https://reviews.apache.org/r/14198/diff/


Testing
-------

ran all test cases


Thanks,

Ryota Egashira