You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/26 05:26:38 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
kezhenxu94 opened a new pull request #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
URL: https://github.com/apache/skywalking/pull/4132
…backend
We don't have release 6.6.0 now, so I use agents in release 6.5.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
URL: https://github.com/apache/skywalking/pull/4132#discussion_r361376515
##########
File path: .github/workflows/e2e.yaml
##########
@@ -50,6 +50,8 @@ jobs:
run: export E2E_VERSION=jdk12-1.3 && bash -x test/e2e/run.sh e2e-single-service
- name: Agent Reboot Tests(JDK8)
run: export E2E_VERSION=jdk8-1.3 && bash -x test/e2e/run.sh e2e-agent-reboot
+ - name: Compatibility (6.x Agents & 7.x Backend)
Review comment:
Let's create a new pipeline for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
URL: https://github.com/apache/skywalking/pull/4132#issuecomment-568982250
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=h1) Report
> Merging [#4132](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e25b1e60085224d78210dc590292ebf939565742?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4132 +/- ##
==========================================
- Coverage 27.25% 27.23% -0.03%
==========================================
Files 1141 1141
Lines 25057 25057
Branches 3625 3625
==========================================
- Hits 6830 6824 -6
- Misses 17620 17627 +7
+ Partials 607 606 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4132/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=footer). Last update [e25b1e6...9799421](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
URL: https://github.com/apache/skywalking/pull/4132#discussion_r361376747
##########
File path: test/e2e/e2e-6.x-agent-7.x-oap-compatibility/src/docker/rc.d/rc0-prepare.sh
##########
@@ -0,0 +1,27 @@
+#!/usr/bin/env bash
+# Licensed to the SkyAPM under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+AGENT_VERSION=6.5.0
+
+ls /sw && echo 'Remove SkyWalking agent directory' && rm -rf /sw/agent && ls /sw
+
+echo 'Download SkyWalking 6.x...' \
+ && curl -o /tmp/sw.tar.gz https://dist.apache.org/repos/dist/release/skywalking/${AGENT_VERSION}/apache-skywalking-apm-${AGENT_VERSION}.tar.gz \
Review comment:
Use dist from here, https://archive.apache.org/dist/skywalking/.
`dist.apache.org` is a mirror site, the release could be removed in some day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
URL: https://github.com/apache/skywalking/pull/4132#issuecomment-568982250
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=h1) Report
> Merging [#4132](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e25b1e60085224d78210dc590292ebf939565742?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4132 +/- ##
==========================================
- Coverage 27.25% 27.17% -0.08%
==========================================
Files 1141 1141
Lines 25057 25057
Branches 3625 3625
==========================================
- Hits 6830 6810 -20
- Misses 17620 17644 +24
+ Partials 607 603 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4132/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4132/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4132/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `73.77% <0%> (-3.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=footer). Last update [e25b1e6...0a7af13](https://codecov.io/gh/apache/skywalking/pull/4132?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4132: Add E2E test case to verify compatibility between 6.x agents and 7.x …
URL: https://github.com/apache/skywalking/pull/4132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services