You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "cshannon (via GitHub)" <gi...@apache.org> on 2023/05/26 14:56:25 UTC
[GitHub] [accumulo] cshannon opened a new pull request, #3432: Make sure existing file path is used for metadata updates
cshannon opened a new pull request, #3432:
URL: https://github.com/apache/accumulo/pull/3432
This fixes instances identified in #3417 where updates to existing files in the metadata table were using the normalized path by mistake and not the existing path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #3432: Make sure existing file path is used for metadata updates
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #3432:
URL: https://github.com/apache/accumulo/pull/3432#issuecomment-1565390101
Full IT passed. As commented on #3435, this PR fixes the test there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #3432: Make sure existing file path is used for metadata updates
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #3432:
URL: https://github.com/apache/accumulo/pull/3432#issuecomment-1564557832
Sunny IT tests passed and I kicked off a full IT build.
Also, I just had a thought that maybe as part of this PR (which only applies in the 2.1 branch where there is still an inheritance relationship) we should actually override https://github.com/apache/accumulo/blob/969fc52f1c5e0c195a8cef800a87e0fab13cd89c/core/src/main/java/org/apache/accumulo/core/metadata/TabletFile.java#L109 and https://github.com/apache/accumulo/blob/969fc52f1c5e0c195a8cef800a87e0fab13cd89c/core/src/main/java/org/apache/accumulo/core/metadata/TabletFile.java#L109
and either throw a new `UnsupportedOperationException` or return the metadataEntry (instead of the normalized path) so we prevent any errors in the future so the normalized path is never used. In #3417 this of course wouldn't be necessary anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #3432: Make sure existing file path is used for metadata updates
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii merged PR #3432:
URL: https://github.com/apache/accumulo/pull/3432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #3432: Make sure existing file path is used for metadata updates
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #3432:
URL: https://github.com/apache/accumulo/pull/3432#issuecomment-1564530049
@keith-turner - This should fix the issues you identified in the other PR. Besides the fix `MetadataTableUtil` in finishSplit(), two spots in `ManagerMetadataUtil` will now use the overloaded putFile() method that takes a StoredTabletFile and uses getMetaUpdateDeleteText().
https://github.com/apache/accumulo/blob/969fc52f1c5e0c195a8cef800a87e0fab13cd89c/server/base/src/main/java/org/apache/accumulo/server/util/ManagerMetadataUtil.java#L97
https://github.com/apache/accumulo/blob/969fc52f1c5e0c195a8cef800a87e0fab13cd89c/server/base/src/main/java/org/apache/accumulo/server/util/ManagerMetadataUtil.java#L205
Do you think we should try and add the IT you were talking about as part of this or create a follow on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org