You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/02/05 23:24:56 UTC
Review Request 30699: SQOOP-1841: Sqoop2: Upgrade from 1.99.1 to
1.99.4 onwards is broken
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30699/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1841
https://issues.apache.org/jira/browse/SQOOP-1841
Repository: sqoop-sqoop2
Description
-------
commit aa8aba0d9b28d4e07d8ea31c118b300b8aba091b
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Feb 4 23:33:59 2015 -0800
SQOOP-1841: Sqoop2: Upgrade from 1.99.1 to 1.99.4 onwards is broken
:100644 100644 c991e5c... f066727... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 ce7b6cb... a242ff9... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java
:100644 100644 606fc68... bf61208... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java c991e5c
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java ce7b6cb
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 606fc68
Diff: https://reviews.apache.org/r/30699/diff/
Testing
-------
Manually tested that the upgrade from 1.99.2 installation to 1.99.5 trunk (latest for sqoop2) gets beyond constraint manipulation. The existence of duplicate names is a problem that will need to be addressed in SQOOP-1790.
Thanks,
Abraham Elmahrek
Re: Review Request 30699: SQOOP-1841: Sqoop2: Upgrade from 1.99.1 to
1.99.4 onwards is broken
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30699/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 12:16 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1841
https://issues.apache.org/jira/browse/SQOOP-1841
Repository: sqoop-sqoop2
Description
-------
commit aa8aba0d9b28d4e07d8ea31c118b300b8aba091b
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Feb 4 23:33:59 2015 -0800
SQOOP-1841: Sqoop2: Upgrade from 1.99.1 to 1.99.4 onwards is broken
:100644 100644 c991e5c... f066727... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 ce7b6cb... a242ff9... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java
:100644 100644 606fc68... bf61208... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
Diffs (updated)
-----
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java 95e3bb8
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f7bab09
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java ce7b6cb
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 46b55bf
Diff: https://reviews.apache.org/r/30699/diff/
Testing
-------
Manually tested that the upgrade from 1.99.2 installation to 1.99.5 trunk (latest for sqoop2) gets beyond constraint manipulation. The existence of duplicate names is a problem that will need to be addressed in SQOOP-1790.
Thanks,
Abraham Elmahrek
Re: Review Request 30699: SQOOP-1841: Sqoop2: Upgrade from 1.99.1 to
1.99.4 onwards is broken
Posted by Jarek Cecho <ja...@apache.org>.
> On Feb. 20, 2015, 6:12 p.m., Jarek Cecho wrote:
> > Ship It!
You will need to rebase the patch Abe - it no longer applies cleanly.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30699/#review73293
-----------------------------------------------------------
On Feb. 5, 2015, 10:24 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30699/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 10:24 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1841
> https://issues.apache.org/jira/browse/SQOOP-1841
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit aa8aba0d9b28d4e07d8ea31c118b300b8aba091b
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Feb 4 23:33:59 2015 -0800
>
> SQOOP-1841: Sqoop2: Upgrade from 1.99.1 to 1.99.4 onwards is broken
>
> :100644 100644 c991e5c... f066727... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 ce7b6cb... a242ff9... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java
> :100644 100644 606fc68... bf61208... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java c991e5c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java ce7b6cb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 606fc68
>
> Diff: https://reviews.apache.org/r/30699/diff/
>
>
> Testing
> -------
>
> Manually tested that the upgrade from 1.99.2 installation to 1.99.5 trunk (latest for sqoop2) gets beyond constraint manipulation. The existence of duplicate names is a problem that will need to be addressed in SQOOP-1790.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 30699: SQOOP-1841: Sqoop2: Upgrade from 1.99.1 to
1.99.4 onwards is broken
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30699/#review73293
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Feb. 5, 2015, 10:24 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30699/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 10:24 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1841
> https://issues.apache.org/jira/browse/SQOOP-1841
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit aa8aba0d9b28d4e07d8ea31c118b300b8aba091b
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Feb 4 23:33:59 2015 -0800
>
> SQOOP-1841: Sqoop2: Upgrade from 1.99.1 to 1.99.4 onwards is broken
>
> :100644 100644 c991e5c... f066727... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 ce7b6cb... a242ff9... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java
> :100644 100644 606fc68... bf61208... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java c991e5c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java ce7b6cb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 606fc68
>
> Diff: https://reviews.apache.org/r/30699/diff/
>
>
> Testing
> -------
>
> Manually tested that the upgrade from 1.99.2 installation to 1.99.5 trunk (latest for sqoop2) gets beyond constraint manipulation. The existence of duplicate names is a problem that will need to be addressed in SQOOP-1790.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>