You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@harmony.apache.org by "Ilya Leviev (JIRA)" <ji...@apache.org> on 2007/03/12 10:23:09 UTC

[jira] Created: (HARMONY-3358) [drlvm][doc] comments for bytecodes.h

[drlvm][doc] comments for bytecodes.h
-------------------------------------

                 Key: HARMONY-3358
                 URL: https://issues.apache.org/jira/browse/HARMONY-3358
             Project: Harmony
          Issue Type: Improvement
          Components: DRLVM
            Reporter: Ilya Leviev


Header file bytecodes.h located in drlvm\trunk\vm\include\open has not enough comments. I have attached the patch that improves it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HARMONY-3358) [drlvm][doc] comments for bytecodes.h

Posted by "Ilya Leviev (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HARMONY-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485982 ] 

Ilya Leviev commented on HARMONY-3358:
--------------------------------------

Nadya, comments verified at r524761.
Thank you for applying this patch.

> [drlvm][doc] comments for bytecodes.h
> -------------------------------------
>
>                 Key: HARMONY-3358
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3358
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Ilya Leviev
>         Assigned To: Nadya Morozova
>         Attachments: HARMONY-3358-add-comments-to-bytecodes-h.patch
>
>
> Header file bytecodes.h located in drlvm\trunk\vm\include\open has not enough comments. I have attached the patch that improves it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (HARMONY-3358) [drlvm][doc] comments for bytecodes.h

Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HARMONY-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nadya Morozova reassigned HARMONY-3358:
---------------------------------------

    Assignee: Nadya Morozova

> [drlvm][doc] comments for bytecodes.h
> -------------------------------------
>
>                 Key: HARMONY-3358
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3358
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Ilya Leviev
>         Assigned To: Nadya Morozova
>         Attachments: HARMONY-3358-add-comments-to-bytecodes-h.patch
>
>
> Header file bytecodes.h located in drlvm\trunk\vm\include\open has not enough comments. I have attached the patch that improves it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HARMONY-3358) [drlvm][doc] comments for bytecodes.h

Posted by "Ilya Leviev (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HARMONY-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Leviev updated HARMONY-3358:
---------------------------------

    Attachment: HARMONY-3358-add-comments-to-bytecodes-h.patch

> [drlvm][doc] comments for bytecodes.h
> -------------------------------------
>
>                 Key: HARMONY-3358
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3358
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Ilya Leviev
>         Attachments: HARMONY-3358-add-comments-to-bytecodes-h.patch
>
>
> Header file bytecodes.h located in drlvm\trunk\vm\include\open has not enough comments. I have attached the patch that improves it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HARMONY-3358) [drlvm][doc] comments for bytecodes.h

Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HARMONY-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480747 ] 

Nadya Morozova commented on HARMONY-3358:
-----------------------------------------

Ilia,
thanks for adding comments to the file. i think the more such patches the better. i'm looking into the patch now, and would ask you to fix the following cosmetic changes:
- tabs used instead of whitespace occasionallyl
- extra opening < symbol at the very bottom of the file at  OPCODE_BREAKPOINT = OPCODE_COUNT    /**< 

> [drlvm][doc] comments for bytecodes.h
> -------------------------------------
>
>                 Key: HARMONY-3358
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3358
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Ilya Leviev
>         Assigned To: Nadya Morozova
>         Attachments: HARMONY-3358-add-comments-to-bytecodes-h.patch
>
>
> Header file bytecodes.h located in drlvm\trunk\vm\include\open has not enough comments. I have attached the patch that improves it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (HARMONY-3358) [drlvm][doc] comments for bytecodes.h

Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HARMONY-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nadya Morozova closed HARMONY-3358.
-----------------------------------


issue verified by submitter. we have nice comments to this file now. other improved comments in interpreter-related headers can be tracked otherwise.

> [drlvm][doc] comments for bytecodes.h
> -------------------------------------
>
>                 Key: HARMONY-3358
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3358
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Ilya Leviev
>         Assigned To: Nadya Morozova
>         Attachments: HARMONY-3358-add-comments-to-bytecodes-h.patch
>
>
> Header file bytecodes.h located in drlvm\trunk\vm\include\open has not enough comments. I have attached the patch that improves it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (HARMONY-3358) [drlvm][doc] comments for bytecodes.h

Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HARMONY-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nadya Morozova resolved HARMONY-3358.
-------------------------------------

    Resolution: Fixed

committed to svn. please verify

> [drlvm][doc] comments for bytecodes.h
> -------------------------------------
>
>                 Key: HARMONY-3358
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3358
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Ilya Leviev
>         Assigned To: Nadya Morozova
>         Attachments: HARMONY-3358-add-comments-to-bytecodes-h.patch
>
>
> Header file bytecodes.h located in drlvm\trunk\vm\include\open has not enough comments. I have attached the patch that improves it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.