You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/06/25 05:10:23 UTC
svn commit: r1750181 - in
/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record:
DocumentEncryptionAtom.java ExOleObjStg.java PersistPtrHolder.java
Author: onealj
Date: Sat Jun 25 05:10:22 2016
New Revision: 1750181
URL: http://svn.apache.org/viewvc?rev=1750181&view=rev
Log:
add @Override annotation for updateOtherRecordReferences on PositionDependentRecordAtom descendents
Modified:
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/DocumentEncryptionAtom.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/ExOleObjStg.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/PersistPtrHolder.java
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/DocumentEncryptionAtom.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/DocumentEncryptionAtom.java?rev=1750181&r1=1750180&r2=1750181&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/DocumentEncryptionAtom.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/DocumentEncryptionAtom.java Sat Jun 25 05:10:22 2016
@@ -39,8 +39,8 @@ import org.apache.poi.util.LittleEndianI
* @author Nick Burch
*/
public final class DocumentEncryptionAtom extends PositionDependentRecordAtom {
- private static long _type = 12052l;
- private byte[] _header;
+ private static final long _type = 12052l;
+ private final byte[] _header;
private EncryptionInfo ei;
/**
@@ -123,7 +123,8 @@ public final class DocumentEncryptionAto
out.write(data, 0, bos.getWriteIndex());
}
+ @Override
public void updateOtherRecordReferences(Map<Integer,Integer> oldToNewReferencesLookup) {
-
+ // nothing to update
}
}
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/ExOleObjStg.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/ExOleObjStg.java?rev=1750181&r1=1750180&r2=1750181&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/ExOleObjStg.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/ExOleObjStg.java Sat Jun 25 05:10:22 2016
@@ -41,7 +41,7 @@ public class ExOleObjStg extends RecordA
/**
* Record header.
*/
- private byte[] _header;
+ private final byte[] _header;
/**
* Record data.
@@ -184,8 +184,8 @@ public class ExOleObjStg extends RecordA
myLastOnDiskOffset = offset;
}
+ @Override
public void updateOtherRecordReferences(Map<Integer,Integer> oldToNewReferencesLookup) {
- return;
+ // nothing to update
}
-
}
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/PersistPtrHolder.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/PersistPtrHolder.java?rev=1750181&r1=1750180&r2=1750181&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/PersistPtrHolder.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/PersistPtrHolder.java Sat Jun 25 05:10:22 2016
@@ -45,7 +45,7 @@ import org.apache.poi.util.POILogger;
public final class PersistPtrHolder extends PositionDependentRecordAtom
{
- private byte[] _header;
+ private final byte[] _header;
private byte[] _ptrData; // Will need to update this once we allow updates to _slideLocations
private long _type;
@@ -159,6 +159,7 @@ public final class PersistPtrHolder exte
* At write-out time, update the references to the sheets to their
* new positions
*/
+ @Override
public void updateOtherRecordReferences(Map<Integer,Integer> oldToNewReferencesLookup) {
// Loop over all the slides we know about
// Find where they used to live, and where they now live
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org