You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2011/07/18 16:11:58 UTC
[jira] [Created] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
hadoop-core JAR contains a log4j.properties file
------------------------------------------------
Key: HADOOP-7468
URL: https://issues.apache.org/jira/browse/HADOOP-7468
Project: Hadoop Common
Issue Type: Bug
Components: build
Affects Versions: 0.20.203.0
Reporter: Steve Loughran
the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7468:
-----------------------------------
Affects Version/s: 1.0.4
1.0.3
still there in 1.04+
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 0.20.203.0, 1.0.3, 1.0.4
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7468:
-----------------------------------
Issue Type: Sub-task (was: Bug)
Parent: HADOOP-7466
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072820#comment-13072820 ]
Steve Loughran commented on HADOOP-7468:
----------------------------------------
I have manually verified that the first patch fixes svn-trunk, while the -for-204 patch fixes the branch-0.20-security-204 branch.
+1
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079823#comment-13079823 ]
Steve Loughran commented on HADOOP-7468:
----------------------------------------
@Matt, No, because a live cluster gets its log4J from conf/ That's why this should not impact any of the script-driven code, server or client -but the file in the JAR does stop any other client app from controlling their logging.
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212606#comment-13212606 ]
Steve Loughran commented on HADOOP-7468:
----------------------------------------
the log4j files should all have been purged from trunk and the artifacts that get stuck in the maven repos on the 0.23.x branch, which addresses my needs...
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079331#comment-13079331 ]
Steve Loughran commented on HADOOP-7468:
----------------------------------------
Incidentally, before a new log4j.properties file is added, you can force commons-logging to go through the java util logger (and hence log@info) by setting
-Dorg.apache.commons.logging.Log=org.apache.commons.logging.impl.Jdk14Logger
That's less than ideal, but is a quick workaround
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079507#comment-13079507 ]
Matt Foley commented on HADOOP-7468:
------------------------------------
If this change causes the HDFS tests to no longer log anything, does it also stop HDFS from logging anything in production?
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran reassigned HADOOP-7468:
--------------------------------------
Assignee: Steve Loughran
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Jolly Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jolly Chen updated HADOOP-7468:
-------------------------------
Attachment: hadoop-7468.txt
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Attachments: hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072823#comment-13072823 ]
Steve Loughran commented on HADOOP-7468:
----------------------------------------
Committed the original patch to trunk, 0.20.204 patch would need approval of the release manager
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079206#comment-13079206 ]
Todd Lipcon commented on HADOOP-7468:
-------------------------------------
This seems to have broken the HDFS tests such that they no longer log anything -- we were apparently depending on those log4j.properties for the test classpath.
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Robert Joseph Evans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-7468:
----------------------------------------
Status: Open (was: Patch Available)
This JIRA has not been touched in a while, and the current patch seems to have broaken HDFS so canceling the patch until at least those issues can be addressed.
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079300#comment-13079300 ]
Steve Loughran commented on HADOOP-7468:
----------------------------------------
OK, this will have to become a "may break things" feature.
Todd, Why didn't you have your own log4j file? the one in hadoop.jar isn't enough to turn your own logging on or off? Was it because with the hadoop.jar's one in the way your own one didn't get picked up?
(IMO, half the problem here is log4j. It should log at info if there is no file, instead of just telling you off. All other log frameworks do this)
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7468:
-----------------------------------
Attachment: hadoop-7468-for-204.patch
This is the same patch for the 0.20.204 branch
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Jolly Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jolly Chen updated HADOOP-7468:
-------------------------------
Status: Patch Available (was: Open)
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Attachments: hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7468) hadoop-core JAR contains a
log4j.properties file
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079302#comment-13079302 ]
Steve Loughran commented on HADOOP-7468:
----------------------------------------
Todd -is there an HDFS issue here I can xref to? I don't want to put the log4j file as that stops any hadoop client app from controlling its own logging. I'd rather fork a copy of the log4j file into hdfs/src/test and give you the power to tune it. And for that I need an HDFS issue. (and I need to get the M3 core build working locally)
> hadoop-core JAR contains a log4j.properties file
> ------------------------------------------------
>
> Key: HADOOP-7468
> URL: https://issues.apache.org/jira/browse/HADOOP-7468
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.20.203.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-7468-for-204.patch, hadoop-7468.txt
>
>
> the hadoop-core JAR in the distribution and in the Maven repositories has a log4j JAR. This can break the logging of any client programs which import that JAR to do things like DFSClient work. It should be stripped from future releases. This should not impact server-side deployments, as the properties file in conf/ should be picked up instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira