[jira] [Commented] (CASSANDRA-2407) Compaction thread should try to empty a bucket before moving on

["Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146321#comment-13146321 ] 

Sylvain Lebresne commented on CASSANDRA-2407:
---------------------------------------------

I can't find where getBackgroundTasks() order the tasks by the size of the bucket (the bucket are create in a HashMap so the order is random if I read this correctly).

Aside from that, I think that whole part of the code, with getBackgroundTasks returning a list of tasks so that we end up only compacting one of them, is a little bit ugly, but refactoring it would be substantial so I guess that's ok for now. 
                
> Compaction thread should try to empty a bucket before moving on
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-2407
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2407
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Stu Hood
>            Assignee: Jonathan Ellis
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.0.3
>
>         Attachments: 2407.txt
>
>
> As suggested by Aaron Morton [(1)|https://issues.apache.org/jira/browse/CASSANDRA-2191?focusedCommentId=13010077&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13010077], a compaction thread should attempt to empty a bucket before moving on to a larger bucket. This would change the submitMinorIfNeeded {{for}} loop into a while loop that regenerated the buckets and started from the bottom after each successful compaction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira