[GitHub] [shardingsphere] Pace2Car commented on a diff in pull request #25145: Add check for CREATE/ALTER SHARDING TABLE RULE with NoneShardingStrategy

["Pace2Car (via GitHub)" <gi...@apache.org>]

Pace2Car commented on code in PR #25145:
URL: https://github.com/apache/shardingsphere/pull/25145#discussion_r1164950789


##########
features/sharding/distsql/handler/src/main/java/org/apache/shardingsphere/sharding/distsql/handler/checker/ShardingTableRuleStatementChecker.java:
##########
@@ -122,6 +123,31 @@ public static boolean isValidBindingTableGroups(final Collection<ShardingTableRe
         return check(toBeCheckedRuleConfig, dataSourceNames);
     }
     
+    private static Collection<String> getRequiredDataSource(final ShardingRuleConfiguration config) {

Review Comment:
   Fixed, THX



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org