You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Alex Sorokoumov (Jira)" <ji...@apache.org> on 2022/11/11 11:51:00 UTC

[jira] [Commented] (FLINK-29987) PartialUpdateITCase.testForeignKeyJo is unstable

    [ https://issues.apache.org/jira/browse/FLINK-29987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632274#comment-17632274 ] 

Alex Sorokoumov commented on FLINK-29987:
-----------------------------------------

As far I understand the flakiness is caused by unconditional {{Thread.sleep}} statement followed by assertion in the test. If the condition does not become true during the fixed sleep period, the assertion fails. I would like to convert this code to something like {{await().atMost(5, SECONDS).until(() -> assert(...));}}

To implement that we can use [https://github.com/awaitility/awaitility] as a test dependency. What do you think?

> PartialUpdateITCase.testForeignKeyJo is unstable
> ------------------------------------------------
>
>                 Key: FLINK-29987
>                 URL: https://issues.apache.org/jira/browse/FLINK-29987
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table Store
>            Reporter: Jingsong Lee
>            Priority: Major
>             Fix For: table-store-0.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)