You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/05/11 00:29:06 UTC

[GitHub] [iceberg] indranildey-sfdc opened a new issue #2580: Allow SchemaToType class to be public so we can extends and override `record` method

indranildey-sfdc opened a new issue #2580:
URL: https://github.com/apache/iceberg/issues/2580


   GOAL
   
   We like to store Custom Avro Properties as JSONIFIED String to Iceberg Schema `doc` by using subclass of SchemaToType class and override `record` method. 
   
   However `SchemaToType` is too restrictive and does not allow us to override the same.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] indranildey-sfdc commented on issue #2580: Allow SchemaToType class to be public so we can extends and override `record` method

Posted by GitBox <gi...@apache.org>.
indranildey-sfdc commented on issue #2580:
URL: https://github.com/apache/iceberg/issues/2580#issuecomment-840016827


   any update on this issue,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] indranildey-sfdc commented on issue #2580: Allow SchemaToType class to be public so we can extends and override `record` method

Posted by GitBox <gi...@apache.org>.
indranildey-sfdc commented on issue #2580:
URL: https://github.com/apache/iceberg/issues/2580#issuecomment-837554970


   Besically `SchemaToType` class should be 
   
   - Public
   - It should have protected Constructor 
   - `Schema root` should protected final
   - `int nextId` should be protected.
   
   These only allow us to override the `record` method in the Iceberg.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org