You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/01 08:10:49 UTC
[GitHub] [shardingsphere] natehuangting opened a new pull request, #18126: JDBCStore For Narayana does not drop tables by default
natehuangting opened a new pull request, #18126:
URL: https://github.com/apache/shardingsphere/pull/18126
Fixes #18124
Changes proposed in this pull request:
- Set the default value of jdbcstore for narayana drop table to false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu merged pull request #18126: JDBCStore For Narayana does not drop tables by default
Posted by GitBox <gi...@apache.org>.
jingshanglu merged PR #18126:
URL: https://github.com/apache/shardingsphere/pull/18126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18126: JDBCStore For Narayana does not drop tables by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18126:
URL: https://github.com/apache/shardingsphere/pull/18126#issuecomment-1143354667
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18126?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18126](https://codecov.io/gh/apache/shardingsphere/pull/18126?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8fa4e9) into [master](https://codecov.io/gh/apache/shardingsphere/commit/64b51d30936ec6d5dd52a8617fc2740b3ad658c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64b51d3) will **increase** coverage by `0.02%`.
> The diff coverage is `55.96%`.
> :exclamation: Current head c8fa4e9 differs from pull request most recent head aba50e9. Consider uploading reports for the commit aba50e9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #18126 +/- ##
============================================
+ Coverage 59.08% 59.10% +0.02%
- Complexity 2165 2171 +6
============================================
Files 3685 3685
Lines 54223 54269 +46
Branches 9210 9221 +11
============================================
+ Hits 32036 32078 +42
+ Misses 19465 19457 -8
- Partials 2722 2734 +12
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...onfig/rule/ShardingAutoTableRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9hcGkvY29uZmlnL3J1bGUvU2hhcmRpbmdBdXRvVGFibGVSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...pi/config/rule/ShardingTableRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9hcGkvY29uZmlnL3J1bGUvU2hhcmRpbmdUYWJsZVJ1bGVDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <ø> (ø)` | |
| [...g/rule/YamlShardingAutoTableRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcveWFtbC9jb25maWcvcnVsZS9ZYW1sU2hhcmRpbmdBdXRvVGFibGVSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [...g/yaml/config/rule/YamlTableRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcveWFtbC9jb25maWcvcnVsZS9ZYW1sVGFibGVSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [.../pipeline/scenario/rulealtered/RuleAlteredJob.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ne/scenario/rulealtered/RuleAlteredJobContext.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../scenario/rulealtered/RuleAlteredJobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iU2NoZWR1bGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...pi/RuleAlteredContextManagerLifecycleListener.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL3NwaS9SdWxlQWx0ZXJlZENvbnRleHRNYW5hZ2VyTGlmZWN5Y2xlTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ry/cache/subscriber/ScalingRegistrySubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9yZWdpc3RyeS9jYWNoZS9zdWJzY3JpYmVyL1NjYWxpbmdSZWdpc3RyeVN1YnNjcmliZXIuamF2YQ==) | `24.00% <ø> (+3.31%)` | :arrow_up: |
| [...le/ShowReadwriteSplittingReadResourcesHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9xdWVyeWFibGUvU2hvd1JlYWR3cml0ZVNwbGl0dGluZ1JlYWRSZXNvdXJjZXNIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/shardingsphere/pull/18126/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18126?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18126?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [06efcbd...aba50e9](https://codecov.io/gh/apache/shardingsphere/pull/18126?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org