You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/12/14 02:56:41 UTC

[GitHub] [incubator-yunikorn-core] yuchaoran2011 commented on a change in pull request #348: [YUNIKORN-896] Updated SI to 0.12.1 and ran go mod tidy

yuchaoran2011 commented on a change in pull request #348:
URL: https://github.com/apache/incubator-yunikorn-core/pull/348#discussion_r768279081



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -1451,7 +1451,7 @@ func (sa *Application) notifyRMAllocationAskReleased(rmID string, released []*Al
 
 func (sa *Application) IsAllocationAssignedToApp(alloc *Allocation) bool {
 	sa.RLock()
-	defer sa.RLock()
+	defer sa.RUnlock()

Review comment:
       This change is already in master. I wonder why it still shows up as a diff?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org