You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/09 02:18:08 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on issue #12190: [Improvement][SPI] Remove duplicate PropertyUtils

EricGao888 commented on issue #12190:
URL: https://github.com/apache/dolphinscheduler/issues/12190#issuecomment-1272434504

   > How about make `task-api` rely on the common module?
   
   FYI, here are the files of `task-api` which `common` depends on:
   
   ```text
   dolphinscheduler.plugin.task.api.enums.TaskExecutionStatus;
   dolphinscheduler.plugin.task.api.enums.TaskTimeoutStrategy;
   dolphinscheduler.plugin.task.api.parameters.TaskTimeoutParameter;
   dolphinscheduler.plugin.task.api.enums.DataType;
   dolphinscheduler.plugin.task.api.enums.Direct;
   dolphinscheduler.plugin.task.api.model.Property;
   dolphinscheduler.plugin.task.api.TaskConstants;
   dolphinscheduler.plugin.task.api.parser.PlaceholderUtils;
   dolphinscheduler.plugin.task.api.parser.TimePlaceholderUtils;
   ```
   
   I need more time to look into them to see whether to move those constant and utility stuff into `common` module or move the code depend on them into `task-api` module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org