You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/04/03 22:21:17 UTC

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #14612: [Numpy] Misc fix

reminisce commented on a change in pull request #14612: [Numpy] Misc fix
URL: https://github.com/apache/incubator-mxnet/pull/14612#discussion_r271953512
 
 

 ##########
 File path: src/ndarray/ndarray.cc
 ##########
 @@ -1711,7 +1711,7 @@ bool NDArray::Load(dmlc::Stream *strm) {
   // load shape
   mxnet::TShape shape;
   if (!shape.Load(strm)) return false;
-  if (shape.ndim() == 0) {
+  if (mxnet::op::shape_is_none(shape)) {
 
 Review comment:
   We may need to check whether the current mode is numpy compatible. If not, we need to conver `shape` to numpy shape first and then call `shape_is_none/shape_is_known`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services