You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Eugene S. Ostrovsky (JIRA)" <ji...@apache.org> on 2007/08/31 12:54:30 UTC

[jira] Created: (HARMONY-4706) [drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor

[drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor
-------------------------------------------------------------------------------------------------

                 Key: HARMONY-4706
                 URL: https://issues.apache.org/jira/browse/HARMONY-4706
             Project: Harmony
          Issue Type: Bug
          Components: DRLVM
         Environment: Windows x86
            Reporter: Eugene S. Ostrovsky


  assert (thread->state & TM_THREAD_STATE_INTERRUPTED);
in hythread_monitor_interrupt_wait()
in thread_native_fat_monitor.c
fails on attempt to interrupt several thread waiting on the same monitor.

This bug causes regression of the following TPTP tests in debug mode:
org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_filter\agg_threadThreadGroupTest_F.xml 
org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_full\agg_threadThreadGroupTest.xml 
org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_filter\threadThreadGroupTest_F.xml 
org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_full\threadThreadGroupTest.xml 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4706) [drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor

Posted by "Eugene S. Ostrovsky (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529885 ] 

Eugene S. Ostrovsky commented on HARMONY-4706:
----------------------------------------------

Bug is fixed.
Regression test should be committed.

> [drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor
> -------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4706
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4706
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Windows x86
>            Reporter: Eugene S. Ostrovsky
>         Attachments: H4706-Regression-test.patch, H4706-Workaround-fix.patch
>
>
>   assert (thread->state & TM_THREAD_STATE_INTERRUPTED);
> in hythread_monitor_interrupt_wait()
> in thread_native_fat_monitor.c
> fails on attempt to interrupt several thread waiting on the same monitor.
> This bug causes regression of the following TPTP tests in debug mode:
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_filter\agg_threadThreadGroupTest_F.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_full\agg_threadThreadGroupTest.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_filter\threadThreadGroupTest_F.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_full\threadThreadGroupTest.xml 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4706) [drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor

Posted by "Eugene S. Ostrovsky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene S. Ostrovsky updated HARMONY-4706:
-----------------------------------------

    Attachment: H4706-Regression-test.patch

Added patch:
  H4706-Regression-test.patch

Regression test for the issue.

> [drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor
> -------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4706
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4706
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Windows x86
>            Reporter: Eugene S. Ostrovsky
>         Attachments: H4706-Regression-test.patch
>
>
>   assert (thread->state & TM_THREAD_STATE_INTERRUPTED);
> in hythread_monitor_interrupt_wait()
> in thread_native_fat_monitor.c
> fails on attempt to interrupt several thread waiting on the same monitor.
> This bug causes regression of the following TPTP tests in debug mode:
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_filter\agg_threadThreadGroupTest_F.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_full\agg_threadThreadGroupTest.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_filter\threadThreadGroupTest_F.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_full\threadThreadGroupTest.xml 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4706) [drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor

Posted by "Eugene S. Ostrovsky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene S. Ostrovsky updated HARMONY-4706:
-----------------------------------------

    Attachment: H4706-Workaround-fix.patch

Added patch:
  H4706-Workaround-fix.patch

Workaround fix.
Before notifying the condvar checks that the thread is waiting on the same monitor it was seen waiting on before.

This fix is not complete because there are still possibilities for race condition:
1. thread is waiting on the same monitor but in the other wait() call.
2. thread was already waiting on the other monitor when it was asked for thread->waited_monitor in interrupter_thread_function()

> [drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor
> -------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4706
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4706
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Windows x86
>            Reporter: Eugene S. Ostrovsky
>         Attachments: H4706-Regression-test.patch, H4706-Workaround-fix.patch
>
>
>   assert (thread->state & TM_THREAD_STATE_INTERRUPTED);
> in hythread_monitor_interrupt_wait()
> in thread_native_fat_monitor.c
> fails on attempt to interrupt several thread waiting on the same monitor.
> This bug causes regression of the following TPTP tests in debug mode:
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_filter\agg_threadThreadGroupTest_F.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_full\agg_threadThreadGroupTest.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_filter\threadThreadGroupTest_F.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_full\threadThreadGroupTest.xml 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-4706) [drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky closed HARMONY-4706.
--------------------------------------

    Resolution: Duplicate
      Assignee: Gregory Shimansky

I am closing this bug as duplicate for  HARMONY-4743 according to evaluation. Regression test committed at 578848. It passes for me.

> [drlvm][thread] assertion fails when interrupting a number of threads waiting on the same monitor
> -------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4706
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4706
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Windows x86
>            Reporter: Eugene S. Ostrovsky
>            Assignee: Gregory Shimansky
>         Attachments: H4706-Regression-test.patch, H4706-Workaround-fix.patch
>
>
>   assert (thread->state & TM_THREAD_STATE_INTERRUPTED);
> in hythread_monitor_interrupt_wait()
> in thread_native_fat_monitor.c
> fails on attempt to interrupt several thread waiting on the same monitor.
> This bug causes regression of the following TPTP tests in debug mode:
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_filter\agg_threadThreadGroupTest_F.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_agg_full\agg_threadThreadGroupTest.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_filter\threadThreadGroupTest_F.xml 
> org.eclipse.tptp.scenario.thread.ThreadGroupTest\standalone_cg_full\threadThreadGroupTest.xml 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.